Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bytecode check #88

Open
hamdiallam opened this issue Dec 12, 2018 · 0 comments
Open

Bytecode check #88

hamdiallam opened this issue Dec 12, 2018 · 0 comments
Assignees
@hamdiallam
Labels
enhancement New feature or request good first issue Good for newcomers question Further information is requested

Comments

@hamdiallam
Copy link
Member

hamdiallam commented Dec 12, 2018 •
edited
Loading

The slice function in BytesUtil is internal, meaning the bytecode is copied to the importing contracts at compile time.

we have more than 1 library using BytesUtil which then gets compiled into PlasmaMVP. Check that the bytecode is not duplicated when compiling PlamaMVP.sol
@hamdiallam hamdiallam added enhancement New feature or request good first issue Good for newcomers question Further information is requested labels Dec 12, 2018
@hamdiallam hamdiallam self-assigned this Dec 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hamdiallam hamdiallam

Labels
enhancement New feature or request good first issue Good for newcomers question Further information is requested
Milestone
No milestone
Development

No branches or pull requests
1 participant
@hamdiallam