Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plasmacli confirmsig query #185

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

wesgraham
Copy link
Contributor

Fixes #161
add support for plasmacli eth query sig <position>

@wesgraham wesgraham changed the title confirmsig query (#161) plasmacli confirmsig query (#161) Jan 3, 2020
@wesgraham wesgraham changed the title plasmacli confirmsig query (#161) plasmacli confirmsig query Jan 3, 2020
@codecov-io
Copy link

codecov-io commented Jan 3, 2020

Codecov Report

Merging #185 into develop will increase coverage by 0.27%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #185      +/-   ##
===========================================
+ Coverage    51.75%   52.02%   +0.27%     
===========================================
  Files           28       28              
  Lines         1314     1359      +45     
===========================================
+ Hits           680      707      +27     
- Misses         529      538       +9     
- Partials       105      114       +9
Impacted Files Coverage Δ
cmd/plasmacli/store/keystore.go 40.5% <0%> (+5.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 77fdee3...667b102. Read the comment docs.

Copy link
Member

@hamdiallam hamdiallam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Looks great.

Can you do a full test? (run a node, submit tx, another tx requiring the confrim signatures, the retrieve the confirm sig using this command; testing when no confirm signatures are present, etc).

client/query.go Outdated Show resolved Hide resolved
client/query.go Show resolved Hide resolved
cmd/plasmacli/subcmd/eth/query/confirmsig.go Show resolved Hide resolved
cmd/plasmacli/subcmd/eth/query/confirmsig.go Outdated Show resolved Hide resolved
client/query.go Show resolved Hide resolved
@wesgraham
Copy link
Contributor Author

Can you do a full test?

Tried depositing on the rootchain and running into a segfault

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Add ability to query for confirmation signatures
4 participants