-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
plasmacli confirmsig query #185
base: develop
Are you sure you want to change the base?
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #185 +/- ##
===========================================
+ Coverage 51.75% 52.02% +0.27%
===========================================
Files 28 28
Lines 1314 1359 +45
===========================================
+ Hits 680 707 +27
- Misses 529 538 +9
- Partials 105 114 +9
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! Looks great.
Can you do a full test? (run a node, submit tx, another tx requiring the confrim signatures, the retrieve the confirm sig using this command; testing when no confirm signatures are present, etc).
Tried depositing on the rootchain and running into a segfault |
Fixes #161
add support for
plasmacli eth query sig <position>