Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finality check for the cli #163

Open
hamdiallam opened this issue Jul 3, 2019 · 1 comment
Open

Finality check for the cli #163

hamdiallam opened this issue Jul 3, 2019 · 1 comment
Assignees
Labels
CLI Issues related to CLI
Milestone

Comments

@hamdiallam
Copy link
Member

hamdiallam commented Jul 3, 2019

Summary

the cli currently has no finality bound check when interacting with the smart contract. include-deposit and deposit can make use of a finality bound in their implementation

Problem

the finality bound parameter was removed in the CLI config file in PR #157 since it was not being used.

Proposal

Implement a finality check where required and reintroduce the parameter in the config

@colin-axner colin-axner added the CLI Issues related to CLI label Jul 15, 2019
@colin-axner colin-axner added this to the Version 2.0 milestone Nov 19, 2019
@hamdiallam
Copy link
Member Author

We should add a plasmad query that allows plasmacli to ask for it's finality bound versus hardcoding the finality parameter. We should also have a persistent --finality flag that allows the user to set a custom finality bound as well

@hamdiallam hamdiallam modified the milestones: Version 2.0, Version 1.0 Feb 28, 2020
@wesgraham wesgraham self-assigned this Mar 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLI Issues related to CLI
Development

No branches or pull requests

3 participants