Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better Tx Decoder #169

Open
hamdiallam opened this issue Jul 21, 2019 · 3 comments
Open

Better Tx Decoder #169

hamdiallam opened this issue Jul 21, 2019 · 3 comments

Comments

@hamdiallam
Copy link
Member

hamdiallam commented Jul 21, 2019

Summary

The current Tx decoder brute forces decoding the tx with RLP

Proposal

Have transaction bytes encoded to a json format

{
 "type": "<msg name>",
 "tx": "<rlp bytes>"
}
@hamdiallam hamdiallam self-assigned this Jul 21, 2019
@hamdiallam
Copy link
Member Author

@colin-axner

do you think amino is an appropriate use case for this? Or use json directly.

I know amino effectively does this same thing for de-serializing types structs

@colin-axner
Copy link
Member

Yea I think you could just wrap the RLP encoded bytes into a struct and register that type on the codec and it should work, but these extra bytes would be included into blocks then, so maybe not?

@hamdiallam
Copy link
Member Author

Yeah, I realized this last night. I'll leave this until after the release

@wesgraham wesgraham added this to the Version 2.0 milestone Feb 28, 2020
@hamdiallam hamdiallam removed their assignment Mar 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

3 participants