Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove ReplayNonce from DepositMsg #172

Open
AdityaSripal opened this issue Aug 8, 2019 · 0 comments
Open

Remove ReplayNonce from DepositMsg #172

AdityaSripal opened this issue Aug 8, 2019 · 0 comments
Milestone
Version 2.0

Comments

@AdityaSripal
Copy link
Member

Used to have ReplayNonce in DepositMsg to avoid tendermint mempool from rejecting replayed tx by using cached txHashes.

Rather than using ReplayNonce to circumvent cache, we could simply set tendermint cache_size = 0.

https://tendermint.com/docs/app-dev/app-development.html#replay-protection

Pros:

  • Remove unnecessary field from DepositMsg

Cons:

  • No longer have lightweight replay protection of mempool cache
@colin-axner colin-axner added this to the Version 2.0 milestone Nov 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
Version 2.0
Development

No branches or pull requests
2 participants
@AdityaSripal @colin-axner