fix: solve static analysis issues

Author: Pryx

composer.json

@@ -21,7 +21,9 @@
         "phpunit/phpunit": "^11.3.1",
         "phpstan/phpstan": "^1.12",
         "squizlabs/php_codesniffer": "^3.10",
-        "slevomat/coding-standard": "^8.15"
+        "slevomat/coding-standard": "^8.15",
+        "phpstan/phpstan-phpunit": "^1.4",
+        "phpstan/extension-installer": "^1.4"
     },
     "autoload": {
         "psr-4": {
@@ -36,13 +38,15 @@
     },
     "config": {
         "allow-plugins": {
-            "dealerdirect/phpcodesniffer-composer-installer": true
+            "dealerdirect/phpcodesniffer-composer-installer": true,
+            "phpstan/extension-installer": true
         }
     },
     "scripts": {
-        "lint": "phpcs",
+        "lint": "phpcs -s",
         "lint-fix": "phpcbf",
         "phpstan": "phpstan analyse -c phpstan.neon",
+        "test": "phpunit",
         "check-quality": [
           "@lint",
           "@phpstan"

composer.lock

@@ -1,6 +1,6 @@
 parameters:
 	level: 8
-	phpVersion: 70400
+	phpVersion: 80100
 
 	tmpDir: %currentWorkingDirectory%/var/tmp/phpstan
 

phpstan.neon

@@ -17,6 +17,9 @@ final class BadRequestException extends FoxentryException
     /**
      * The HTTP status code associated with this exception.
      *
+     * @var int
      */
-    protected int $code = 400;
+    // Native typehint missing, because definition needs to match the native Exception class.
+    // phpcs:ignore SlevomatCodingStandard.TypeHints.PropertyTypeHint.MissingNativeTypeHint
+    protected $code = 400;
 }

src/Exception/BadRequestException.php

@@ -17,6 +17,9 @@ final class ForbiddenException extends FoxentryException
     /**
      * The HTTP status code associated with this exception.
      *
+     * @var int
      */
-    protected int $code = 403;
+    // Native typehint missing, because definition needs to match the native Exception class.
+    // phpcs:ignore SlevomatCodingStandard.TypeHints.PropertyTypeHint.MissingNativeTypeHint
+    protected $code = 403;
 }

src/Exception/ForbiddenException.php

@@ -24,7 +24,7 @@ public static function fromRequestException(RequestException $e): self
     {
         // Check if the exception has a response
         if ($e->hasResponse()) {
-            $statusCode = $e->getResponse()->getStatusCode();
+            $statusCode = $e->getResponse()?->getStatusCode() ?? -1;
             // Switch based on the status code of the response
             switch ($statusCode) {
                 case 400:
@@ -55,17 +55,18 @@ public static function fromRequestException(RequestException $e): self
                     break;
                 default:
                     // Handle the rest with generic FoxentryException class
-                    $foxentryException = new self("Request exception: " . $e->getResponse()->getBody()->getContents(), $statusCode);
+                    $foxentryException = new self("Request exception: " . $e->getMessage(), $statusCode);
                     break;
             }
+
             return  $foxentryException->setResponse($e->getResponse());
         }
 
         // Return a generic exception with the original exception message
         return new self("Exception: " . $e->getMessage());
     }
 
-    public function setResponse(ResponseInterface $response): self
+    public function setResponse(?ResponseInterface $response): self
     {
         $this->response = $response;
         return $this;

src/Exception/FoxentryException.php

@@ -17,6 +17,9 @@ final class NotFoundException extends FoxentryException
     /**
      * The HTTP status code associated with this exception.
      *
+     * @var int
      */
-    protected int $code = 404;
+    // Native typehint missing, because definition needs to match the native Exception class.
+    // phpcs:ignore SlevomatCodingStandard.TypeHints.PropertyTypeHint.MissingNativeTypeHint
+    protected $code = 404;
 }

src/Exception/NotFoundException.php

@@ -17,6 +17,9 @@ final class PaymentRequiredException extends FoxentryException
     /**
      * The HTTP status code associated with this exception.
      *
+     * @var int
      */
-    protected int $code = 402;
+    // Native typehint missing, because definition needs to match the native Exception class.
+    // phpcs:ignore SlevomatCodingStandard.TypeHints.PropertyTypeHint.MissingNativeTypeHint
+    protected $code = 402;
 }

src/Exception/PaymentRequiredException.php

@@ -17,6 +17,9 @@ final class ServerErrorException extends FoxentryException
     /**
      * The HTTP status code associated with this exception.
      *
+     * @var int
      */
-    protected int $code = 500;
+    // Native typehint missing, because definition needs to match the native Exception class.
+    // phpcs:ignore SlevomatCodingStandard.TypeHints.PropertyTypeHint.MissingNativeTypeHint
+    protected $code = 500;
 }

src/Exception/ServerErrorException.php

@@ -17,6 +17,9 @@ final class ServiceUnavailableException extends FoxentryException
     /**
      * The HTTP status code associated with this exception.
      *
+     * @var int
      */
-    protected int $code = 503;
+    // Native typehint missing, because definition needs to match the native Exception class.
+    // phpcs:ignore SlevomatCodingStandard.TypeHints.PropertyTypeHint.MissingNativeTypeHint
+    protected $code = 503;
 }