Fix nodes& nodes parameter shadowing in registrar constructor

Copilot · greenc-FNAL · greenc-FNAL · commit 63f563c86055 · 2026-03-03T17:31:49.000-06:00
Co-authored-by: greenc-FNAL &lt;2372949+greenc-FNAL@users.noreply.github.com&gt;
diff --git a/phlex/core/registrar.hpp b/phlex/core/registrar.hpp
@@ -67,8 +67,8 @@ namespace phlex::experimental {
     using node_creator = std::function<Ptr(std::vector<std::string>, std::vector<std::string>)>;
 
   public:
-    explicit registrar(nodes& nodes, std::vector<std::string>& errors) :
-      nodes_{&nodes}, errors_{&errors}
+    explicit registrar(nodes& node_map, std::vector<std::string>& errors) :
+      nodes_{&node_map}, errors_{&errors}
     {
     }
 

Original file line number	Diff line number	Diff line change
`@@ -67,8 +67,8 @@ namespace phlex::experimental {`
`67`	`67`	`using node_creator = std::function<Ptr(std::vector<std::string>, std::vector<std::string>)>;`
`68`	`68`
`69`	`69`	`public:`
`70`		`- explicit registrar(nodes& nodes, std::vector<std::string>& errors) :`
`71`		`- nodes_{&nodes}, errors_{&errors}`
	`70`	`+ explicit registrar(nodes& node_map, std::vector<std::string>& errors) :`
	`71`	`+ nodes_{&node_map}, errors_{&errors}`
`72`	`72`	`{`
`73`	`73`	`}`
`74`	`74`