Revert "Improve test coverage of Phlex code"

This reverts commit 73af4a6.

Author: greenc-FNAL

phlex/model/identifier.hpp

@@ -57,14 +57,6 @@ namespace phlex::experimental {
   inline std::string_view format_as(identifier const& id) { return std::string_view(id); }
 }
 
-template <>
-struct fmt::formatter<phlex::experimental::identifier> : formatter<std::string_view> {
-  auto format(phlex::experimental::identifier const& id, format_context& ctx) const
-  {
-    return formatter<std::string_view>::format(std::string_view(id), ctx);
-  }
-};
-
 template <>
 struct std::hash<phlex::experimental::identifier> {
   std::size_t operator()(phlex::experimental::identifier const& id) const noexcept

test/CMakeLists.txt

@@ -204,10 +204,6 @@ cet_test(
 cet_test(product_query USE_CATCH2_MAIN SOURCE product_query.cpp LIBRARIES
          phlex::core
 )
-cet_test(core_misc_test USE_CATCH2_MAIN SOURCE core_misc_test.cpp LIBRARIES
-         phlex::core
-         Boost::json
-)
 cet_test(
   provider_test
   USE_CATCH2_MAIN

test/core_misc_test.cpp

@@ -23,50 +23,3 @@ TEST_CASE("Verify independent hashes", "[data model]")
   CHECK(event_760->hash() != event_4999->hash());
   CHECK(event_760->layer_hash() == event_4999->layer_hash());
 }
-
-TEST_CASE("data_cell_index methods", "[data model]")
-{
-  auto base = data_cell_index::base_ptr();
-  auto run0 = base->make_child(0, "run");
-  auto run1 = base->make_child(1, "run");
-
-  SECTION("Comparisons")
-  {
-    CHECK(*run0 < *run1);
-    CHECK_FALSE(*run1 < *run0);
-    CHECK_FALSE(*run0 < *run0);
-
-    auto subrun0 = run0->make_child(0, "subrun");
-    auto subrun1 = run0->make_child(1, "subrun");
-    CHECK(*subrun0 < *subrun1);
-    CHECK(*run0 < *subrun0);
-  }
-
-  SECTION("to_string")
-  {
-    auto subrun = run0->make_child(5, "subrun");
-    CHECK(subrun->to_string() == "[run:0, subrun:5]");
-    CHECK(base->to_string() == "[]");
-
-    auto nameless = base->make_child(10, "");
-    CHECK(nameless->to_string() == "[10]");
-  }
-
-  SECTION("Parent lookup")
-  {
-    auto subrun = run0->make_child(5, "subrun");
-    auto event = subrun->make_child(100, "event");
-
-    CHECK(event->parent("subrun") == subrun);
-    CHECK(event->parent("run") == run0);
-    CHECK(event->parent("nonexistent") == nullptr);
-  }
-
-  SECTION("Layer path")
-  {
-    auto subrun = run0->make_child(5, "subrun");
-    CHECK(subrun->layer_path() == "/job/run/subrun");
-  }
-
-  SECTION("Base access") { CHECK(&data_cell_index::base() == data_cell_index::base_ptr().get()); }
-}

test/data_cell_index.cpp

@@ -65,15 +65,5 @@ int main()
     }
   }
   assert(ok);
-
-  // Additional coverage for identifier edge cases
-  identifier id1("abc");
-  identifier id2("def");
-  assert(id1 == id1);
-  assert(id1 != id2);
-  assert(id1 < id2 || id2 < id1);
-  assert(id1 <= id1);
-  assert(id1 >= id1);
-
   return 0;
 }