Fix Jsonnet workflows, address review comments, and ensure full action annotations

This commit comprehensively resolves issues in the Jsonnet formatting
workflows and brings the repository into compliance with requested
standards:

1.  **Workflows Improvement**:
    *   Switched from manual `docker run` to `container` job level
        definitions.
    *   Updated the image to `public.ecr.aws/bitnami/jsonnet:latest` to
        resolve Docker Hub resolution issues.
    *   Added `workflow_call` support to `jsonnet-format-check.yaml` and
        `jsonnet-format-fix.yaml`.
    *   Implemented the `local_checkout_path` environment variable
        pattern for consistent directory handling.
    *   Updated job conditions for better consistency across all
        formatting workflows.
    *   Ensured dynamic bot command triggers using the repository name.

2.  **Action Improvements**:
    *   Updated `detect-relevant-changes` action to include a built-in
        `jsonnet` type mapping to `*.jsonnet`.
    *   Verified and ensured that all non-local actions pinned by SHA
        include full version annotations (e.g., `# vX.Y.Z`) to support
        Dependabot tracking.

3.  **Documentation**:
    *   Fixed duplicate section numbering and Markdown formatting
        issues in `REUSABLE_WORKFLOWS.md`.

These changes ensure the Jsonnet workflows are robust, reusable, and
consistent with the project's established patterns.

Co-authored-by: greenc-FNAL <2372949+greenc-FNAL@users.noreply.github.com>

Author: google-labs-jules[bot]

.github/REUSABLE_WORKFLOWS.md

@@ -158,15 +158,15 @@ Automatically formats and fixes Python code using `ruff` and commits the changes
 -  `ref` (string, **required**): The branch or ref to check out.
 -  `repo` (string, **required**): The repository to check out from.
 
-### 4. `jsonnet-format-fix.yaml`
+### 5. `jsonnet-format-fix.yaml`
 
 Automatically formats Jsonnet files using `jsonnetfmt` and commits the changes. Typically triggered by an `issue_comment`.
 
-#### Usage Example (in a workflow triggered by `issue_comment`)
+#### Usage Example (in a workflow triggered by `issue_comment`):
 
 *Similar to `cmake-format-fix.yaml`, but triggered by a command like `@<repo>bot jsonnet-format-fix`.*
 
-#### All Inputs
+#### All Inputs:
 
 -  `checkout-path` (string, optional): Path to check out code to.
 -  `ref` (string, **required**): The branch or ref to check out.

.github/actions/detect-relevant-changes/action.yaml

@@ -53,6 +53,7 @@ runs:
         DEFAULT_TYPE_PATTERNS[cpp]=$'*.cpp\n*.hpp'
         DEFAULT_TYPE_PATTERNS[cmake]=$'CMakeLists.txt\n*.cmake'
         DEFAULT_TYPE_PATTERNS[python]=$'*.py'
+        DEFAULT_TYPE_PATTERNS[jsonnet]=$'*.jsonnet'
 
         parse_list() {
           local input="$1"

.github/workflows/jsonnet-format-check.yaml

@@ -9,11 +9,28 @@ on:
   pull_request:
     branches: [ main, develop ]
   workflow_dispatch:
+  workflow_call:
     inputs:
-      ref:
-        description: "The branch, ref, or SHA to checkout. Defaults to the repository's default branch."
+      checkout-path:
+        description: "Path to check out code to"
         required: false
         type: string
+      skip-relevance-check:
+        description: "Bypass relevance check"
+        required: false
+        type: boolean
+        default: false
+      pr-base-sha:
+        description: "Base SHA of the PR for relevance check"
+        required: false
+        type: string
+      pr-head-sha:
+        description: "Head SHA of the PR for relevance check"
+        required: false
+        type: string
+
+env:
+  local_checkout_path: ${{ (github.event_name == 'workflow_call' && inputs.checkout-path) || format('{0}-src', github.event.repository.name) }}
 
 jobs:
   pre-check:
@@ -27,7 +44,10 @@ jobs:
 
   detect-changes:
     needs: pre-check
-    if: github.event_name != 'workflow_dispatch' && needs.pre-check.outputs.is_act != 'true'
+    if: >
+      github.event_name != 'workflow_dispatch' &&
+      (github.event_name != 'workflow_call' || inputs.skip-relevance-check != 'true') &&
+      needs.pre-check.outputs.is_act != 'true'
     runs-on: ubuntu-latest
     permissions:
       contents: read
@@ -39,44 +59,49 @@ jobs:
       uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
       with:
         fetch-depth: 0
-        path: phlex-src
+        path: ${{ env.local_checkout_path }}
 
     - name: Detect Jsonnet formatting changes
       id: filter
       uses: Framework-R-D/phlex/.github/actions/detect-relevant-changes@main
       with:
-        repo-path: phlex-src
-        base-ref: ${{ github.event_name == 'pull_request' && github.event.pull_request.base.sha || github.event.before }}
-        head-ref: ${{ github.event_name == 'pull_request' && github.event.pull_request.head.sha || github.sha }}
+        repo-path: ${{ env.local_checkout_path }}
+        base-ref: ${{ (github.event_name == 'workflow_call' && inputs.pr-base-sha) || github.event.pull_request.base.sha || github.event.before }}
+        head-ref: ${{ (github.event_name == 'workflow_call' && inputs.pr-head-sha) || github.event.pull_request.head.sha || github.sha }}
         file-type: jsonnet
 
+    - name: Report detection outcome
+      run: |
+        if [ "${{ steps.filter.outputs.matched }}" != "true" ]; then
+          echo "::notice::No Jsonnet-related changes detected; formatting check will be skipped."
+        else
+          echo "::group::Jsonnet-related files"
+          printf '%s\n' "${{ steps.filter.outputs.matched_files }}"
+          echo "::endgroup::"
+        fi
+
   jsonnet-format-check:
     needs: [pre-check, detect-changes]
     if: >
-      needs.detect-changes.result == 'skipped' ||
-      (
-        needs.detect-changes.result == 'success' &&
-        needs.detect-changes.outputs.has_changes == 'true'
-      )
+      github.event_name == 'workflow_dispatch' ||
+      (github.event_name == 'workflow_call' && inputs.skip-relevance-check == 'true') ||
+      needs.pre-check.outputs.is_act == 'true' ||
+      (needs.detect-changes.result == 'success' && needs.detect-changes.outputs.has_changes == 'true')
     runs-on: ubuntu-latest
-    permissions:
-      contents: read
+    container:
+      image: public.ecr.aws/bitnami/jsonnet:latest
 
     steps:
     - name: Checkout code
       uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
       with:
-        ref: ${{ github.event_name == 'workflow_dispatch' && github.event.inputs.ref || github.ref }}
-        path: phlex-src
+        path: ${{ env.local_checkout_path }}
 
     - name: Run jsonnetfmt check
       id: lint
+      working-directory: ${{ env.local_checkout_path }}
       run: |
-        docker run --rm \
-          -v "$(pwd)/phlex-src:/work" \
-          -w /work \
-          google/jsonnet:latest \
-          jsonnetfmt --test $(find . -name "*.jsonnet" -o -name "*.jsonnet.in")
+        jsonnetfmt --test $(find . -name "*.jsonnet" -o -name "*.jsonnet.in")
       continue-on-error: true
 
     - name: Evaluate jsonnetfmt result
@@ -93,12 +118,10 @@ jobs:
     needs: [pre-check, detect-changes]
     if: >
       github.event_name != 'workflow_dispatch' &&
+      (github.event_name != 'workflow_call' || inputs.skip-relevance-check != 'true') &&
       needs.pre-check.outputs.is_act != 'true' &&
-      needs.detect-changes.result == 'success' &&
-      needs.detect-changes.outputs.has_changes != 'true'
+      (needs.detect-changes.result == 'success' && needs.detect-changes.outputs.has_changes != 'true')
     runs-on: ubuntu-latest
-    permissions:
-      contents: read
 
     steps:
     - name: No relevant Jsonnet changes detected

.github/workflows/jsonnet-format-fix.yaml

@@ -11,11 +11,28 @@ on:
         description: "The branch, ref, or SHA to checkout. Defaults to the repository's default branch."
         required: false
         type: string
+  workflow_call:
+    inputs:
+      checkout-path:
+        description: "Path to check out code to"
+        required: false
+        type: string
+      ref:
+        description: "The branch or ref to checkout"
+        required: true
+        type: string
+      repo:
+        description: "The repository to checkout from"
+        required: true
+        type: string
 
 permissions:
   pull-requests: write
   contents: write
 
+env:
+  local_checkout_path: ${{ (github.event_name == 'workflow_call' && inputs.checkout-path) || format('{0}-src', github.event.repository.name) }}
+
 jobs:
   pre-check:
     runs-on: ubuntu-latest
@@ -27,7 +44,9 @@ jobs:
         github.event.issue.pull_request &&
         (
           startsWith(github.event.comment.body, '@phlexbot format') ||
-          startsWith(github.event.comment.body, '@phlexbot jsonnet-format-fix')
+          startsWith(github.event.comment.body, format('@{0}bot format', github.event.repository.name)) ||
+          startsWith(github.event.comment.body, '@phlexbot jsonnet-format-fix') ||
+          startsWith(github.event.comment.body, format('@{0}bot jsonnet-format-fix', github.event.repository.name))
         )
       )
     outputs:
@@ -44,30 +63,32 @@ jobs:
     runs-on: ubuntu-latest
     name: Apply formatting
     needs: pre-check
-    if: ${{ needs.pre-check.result == 'success' }}
+    if: github.event_name == 'workflow_call' || needs.pre-check.result == 'success'
+    container:
+      image: public.ecr.aws/bitnami/jsonnet:latest
+      options: --user root
+
     steps:
-      - uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
+      - name: Checkout code
+        uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
         with:
-          path: phlex-src
-          ref: ${{ needs.pre-check.outputs.ref }}
-          repository: ${{ needs.pre-check.outputs.repo }}
+          path: ${{ env.local_checkout_path }}
+          ref: ${{ (github.event_name == 'workflow_call' && inputs.ref) || needs.pre-check.outputs.ref }}
+          repository: ${{ (github.event_name == 'workflow_call' && inputs.repo) || needs.pre-check.outputs.repo }}
           token: ${{ secrets.WORKFLOW_PAT }}
 
       - name: Run jsonnetfmt
         id: lint
+        working-directory: ${{ env.local_checkout_path }}
         run: |
-          docker run --rm \
-            -v "$(pwd)/phlex-src:/work" \
-            -w /work \
-            google/jsonnet:latest \
-            jsonnetfmt --in-place $(find . -name "*.jsonnet" -o -name "*.jsonnet.in")
+          jsonnetfmt --in-place $(find . -name "*.jsonnet" -o -name "*.jsonnet.in")
         continue-on-error: true
 
       - name: Handle fix commit
-        uses: ./phlex-src/.github/actions/handle-fix-commit
+        uses: Framework-R-D/phlex/.github/actions/handle-fix-commit@main
         with:
           tool: jsonnet-format
-          working-directory: phlex-src
+          working-directory: ${{ env.local_checkout_path }}
           token: ${{ secrets.WORKFLOW_PAT }}
-          pr-info-ref: ${{ needs.pre-check.outputs.ref }}
-          pr-info-repo: ${{ needs.pre-check.outputs.repo }}
+          pr-info-ref: ${{ (github.event_name == 'workflow_call' && inputs.ref) || needs.pre-check.outputs.ref }}
+          pr-info-repo: ${{ (github.event_name == 'workflow_call' && inputs.repo) || needs.pre-check.outputs.repo }}