fix: wire workflow_call inputs, act fallback for change detection, and correct clang-tidy/format-all failure behavior (#421)

* Initial plan

* fix: wire workflow_call inputs, act fallback for change detection, and clang-tidy/format-all failures

Co-authored-by: greenc-FNAL <2372949+greenc-FNAL@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: greenc-FNAL <2372949+greenc-FNAL@users.noreply.github.com>

Author: Copilot

.github/actions/workflow-setup/action.yaml

@@ -57,7 +57,7 @@ outputs:
     value: ${{ steps.prepare.outputs.build_path }}
   has_changes:
     description: "Whether relevant changes were detected"
-    value: ${{ steps.detect.outputs.has_changes }}
+    value: ${{ steps.changes.outputs.has_changes }}
 
 runs:
   using: "composite"
@@ -112,7 +112,7 @@ runs:
 
     - name: Run change detection
       id: detect
-      if: inputs.file-type != '' || inputs.include-globs != ''
+      if: (inputs.file-type != '' || inputs.include-globs != '') && steps.prepare.outputs.is_act != 'true'
       uses: Framework-R-D/phlex/.github/actions/run-change-detection@main
       with:
         checkout-path: ${{ steps.prepare.outputs.checkout_path }}
@@ -123,3 +123,14 @@ runs:
         include-globs: ${{ inputs.include-globs }}
         exclude-globs: ${{ inputs.exclude-globs }}
         head-ref: ${{ inputs.head-ref }}
+
+    - name: Set has_changes output
+      id: changes
+      shell: bash
+      run: |
+        if [ "${{ steps.prepare.outputs.is_act }}" = "true" ] && \
+           ([ "${{ inputs.file-type }}" != "" ] || [ "${{ inputs.include-globs }}" != "" ]); then
+          echo "has_changes=true" >> "$GITHUB_OUTPUT"
+        else
+          echo "has_changes=${{ steps.detect.outputs.has_changes }}" >> "$GITHUB_OUTPUT"
+        fi

.github/workflows/actionlint-check.yaml

@@ -63,6 +63,10 @@ jobs:
             .github/actions/**/*.yml
             .github/actions/**/*.yaml
           head-ref: ${{ inputs.pr-head-sha }}
+          ref: ${{ inputs.ref }}
+          repo: ${{ inputs.repo }}
+          pr-base-sha: ${{ inputs.pr-base-sha }}
+          checkout-path: ${{ inputs.checkout-path }}
 
   actionlint-check:
     needs: setup

.github/workflows/clang-tidy-check.yaml

@@ -91,6 +91,7 @@ jobs:
             exit 1
           elif grep -qE '^/.+\.(cpp|hpp|c|h):[0-9]+:[0-9]+: (warning|error):' clang-tidy.log; then
             echo "::warning::Clang-tidy found issues in the code"
+            exit 1
           else
             echo "✅ clang-tidy check passed"
           fi

.github/workflows/cmake-format-check.yaml

@@ -59,6 +59,10 @@ jobs:
         with:
           file-type: cmake
           head-ref: ${{ inputs.pr-head-sha }}
+          ref: ${{ inputs.ref }}
+          repo: ${{ inputs.repo }}
+          pr-base-sha: ${{ inputs.pr-base-sha }}
+          checkout-path: ${{ inputs.checkout-path }}
 
   cmake-format-check:
     needs: setup

.github/workflows/format-all.yaml

@@ -120,3 +120,9 @@ jobs:
         uses: Framework-R-D/phlex/.github/actions/complete-pr-comment@main
         with:
           status: ${{ steps.collect.outputs.has_failures == 'true' && 'failure' || 'success' }}
+
+      - name: Fail on formatter failures
+        if: steps.collect.outputs.has_failures == 'true'
+        run: |
+          echo "One or more formatters failed, were canceled, or were skipped."
+          exit 1

.github/workflows/header-guards-check.yaml

@@ -59,6 +59,10 @@ jobs:
         with:
           file-type: cpp
           head-ref: ${{ inputs.pr-head-sha }}
+          ref: ${{ inputs.ref }}
+          repo: ${{ inputs.repo }}
+          pr-base-sha: ${{ inputs.pr-base-sha }}
+          checkout-path: ${{ inputs.checkout-path }}
 
   header-guards-check:
     needs: setup

.github/workflows/jsonnet-format-check.yaml

@@ -59,6 +59,10 @@ jobs:
         with:
           file-type: jsonnet
           head-ref: ${{ inputs.pr-head-sha }}
+          ref: ${{ inputs.ref }}
+          repo: ${{ inputs.repo }}
+          pr-base-sha: ${{ inputs.pr-base-sha }}
+          checkout-path: ${{ inputs.checkout-path }}
 
   jsonnet-format-check:
     needs: setup

.github/workflows/markdown-check.yaml

@@ -59,6 +59,10 @@ jobs:
         with:
           file-type: md
           head-ref: ${{ inputs.pr-head-sha }}
+          ref: ${{ inputs.ref }}
+          repo: ${{ inputs.repo }}
+          pr-base-sha: ${{ inputs.pr-base-sha }}
+          checkout-path: ${{ inputs.checkout-path }}
 
   markdown-check:
     needs: setup

.github/workflows/python-check.yaml

@@ -59,6 +59,10 @@ jobs:
         with:
           file-type: python
           head-ref: ${{ inputs.pr-head-sha }}
+          ref: ${{ inputs.ref }}
+          repo: ${{ inputs.repo }}
+          pr-base-sha: ${{ inputs.pr-base-sha }}
+          checkout-path: ${{ inputs.checkout-path }}
 
   python-check:
     needs: setup