Remove redundant INSTALL_INTERFACE from phlex_apply_symbol_visibility

Copilot · pcanal · Copilot · commit fb2153b7ec4b · 2026-03-09T20:26:53.000Z
cetmodules adds INSTALL_INTERFACE:include to every target it creates via
cet_make_library, so the explicit INSTALL_INTERFACE:include entry in
phlex_apply_symbol_visibility was a no-op duplicate. The only unique
contribution of the target_include_directories call is the
BUILD_INTERFACE to ${PROJECT_BINARY_DIR}/include, which is where
generate_export_header writes the generated phlex/X_export.hpp headers.

Co-authored-by: pcanal &lt;5175087+pcanal@users.noreply.github.com&gt;
diff --git a/Modules/private/PhlexSymbolVisibility.cmake b/Modules/private/PhlexSymbolVisibility.cmake
@@ -18,8 +18,7 @@ function(phlex_apply_symbol_visibility target)
   )
 
   target_include_directories(
-    ${target}
-    PUBLIC $<BUILD_INTERFACE:${PROJECT_BINARY_DIR}/include> $<INSTALL_INTERFACE:include>
+    ${target} PUBLIC $<BUILD_INTERFACE:${PROJECT_BINARY_DIR}/include>
   )
 
   install(FILES "${EXPORT_HEADER}" DESTINATION include/phlex)

Original file line number	Diff line number	Diff line change
`@@ -18,8 +18,7 @@ function(phlex_apply_symbol_visibility target)`
`18`	`18`	`)`
`19`	`19`
`20`	`20`	`target_include_directories(`
`21`		`- ${target}`
`22`		`- PUBLIC $<BUILD_INTERFACE:${PROJECT_BINARY_DIR}/include> $<INSTALL_INTERFACE:include>`
	`21`	`+ ${target} PUBLIC $<BUILD_INTERFACE:${PROJECT_BINARY_DIR}/include>`
`23`	`22`	`)`
`24`	`23`
`25`	`24`	`install(FILES "${EXPORT_HEADER}" DESTINATION include/phlex)`