Remove get_string_view()

Author: beojan

phlex/core/product_query.cpp

@@ -30,7 +30,7 @@ namespace phlex {
   bool product_query::match(experimental::product_specification const& spec) const
   {
     // string comparisons for now for a gradual transition
-    if (creator.get_string_view() != spec.algorithm()) {
+    if (std::string_view(creator) != spec.algorithm()) {
       return false;
     }
     if (type != spec.type()) {

phlex/core/product_query.hpp

@@ -24,7 +24,7 @@ namespace phlex {
       {
         static_assert(false, "The creator name has not been set in this product_query.");
       }
-      required_creator_name(T&& rhs) : content_(std::forward<T>(rhs))
+      required_creator_name(T&& rhs) : content_(std::move(rhs))
       {
         if (content_.empty()) {
           throw std::runtime_error("Cannot specify product with empty creator name.");
@@ -33,9 +33,6 @@ namespace phlex {
 
       operator T const&() const noexcept { return content_; }
 
-      // For the transition
-      std::string_view get_string_view() const noexcept { return std::string_view(content_); }
-
     private:
       experimental::identifier content_;
     };
@@ -58,9 +55,6 @@ namespace phlex {
 
       operator T const&() const noexcept { return content_; }
 
-      // For the transition
-      std::string_view get_string_view() const noexcept { return std::string_view(content_); }
-
     private:
       experimental::identifier content_;
     };