Actually using the new product_query (Part 1)#344
Actually using the new product_query (Part 1)#344knoepfel merged 38 commits intoFramework-R-D:mainfrom
Conversation
Won't build yet
This handles the API change, and ports the existing creator name check to work with the new product_query.
Also use std::unreachable() instead of kind = "HOW??"s;
- Introduce `identifier` - Combine `product_query` and `product_tag` - Express above in terms of `identifier` - Changes to make everything work again
Mostly compilation errors, plus exception change in configuration test
Codecov Report❌ Patch coverage is @@ Coverage Diff @@
## main #344 +/- ##
==========================================
+ Coverage 86.51% 86.67% +0.16%
==========================================
Files 119 119
Lines 2403 2462 +59
Branches 387 391 +4
==========================================
+ Hits 2079 2134 +55
- Misses 206 210 +4
Partials 118 118
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 3 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
beojan
changed the title
|
@phlexbot format |
|
No automatic header-guards fixes were necessary. |
|
No automatic markdownlint fixes were necessary. |
|
No automatic jsonnetfmt fixes were necessary. |
|
No automatic cmake-format fixes were necessary. |
|
Automatic clang-format fixes pushed (commit 3c48ce0). |
|
@phlexbot format |
|
No automatic header-guards fixes were necessary. |
|
No automatic cmake-format fixes were necessary. |
|
No automatic jsonnetfmt fixes were necessary. |
|
No automatic markdownlint fixes were necessary. |
|
Automatic YAML formatter fixes pushed (commit dbc49a6). |
|
Automatic clang-format fixes pushed (commit 7eff32f). |
|
@beojan, this looks good. Some conflicts need some resolution but then we should be good to go. |
|
Fixed the conflicts, but it needs to be approved again. |
2 participants
Mostly switching to using
identifiermembers, along with adding the ability to resolve products without a suffix.