type checking for the project? #459
swamper123
started this conversation in
General
Replies: 1 comment
-
We have already started adding typing several places. Found a few one directly wrong yesterday btw |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
I wanted to ask, what your opinion is about Type checking in the project.
Should we strive to add type annotations in future code? To add a type checker (e.g. like mypy) to our actions?
My opinion is, that this may help us to be more clear in our code and being able to express excatly what kind of e.g. parameter/s should be expected. I don't want to rejig the library in one PR (since that would be massive work), I think that it would be best (not mandatory) practice for future PRs. But this is just my opinion on that topic.
Beta Was this translation helpful? Give feedback.
All reactions