Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix _Cellular_AtcmdDataSend interDelayMS #155

Merged
merged 3 commits into from
Oct 23, 2023

Conversation

chinglee-iot
Copy link
Member

@chinglee-iot chinglee-iot commented Oct 20, 2023

Fix the inter delay for _Cellular_AtcmdDataSend

Description

interDelayMS is designed to adapt the behavior of cellular modem that a minimum delay is required before sending data.

For example, after the @ prompt reception, SARA-R4 AT command +USOWR requires the cellular library to wait for a minimum 50ms before sending data.

The delay should happen after data send command success but before sending data. This PR fix the interDelayMS.

  • Move the delay to code between the data send command success and sending data.

Test Steps

Running SARA-R4 demo without problem.

Checklist:

  • I have tested my changes. No regression in existing tests.
  • I have modified and/or added unit-tests to cover the code changes in this Pull Request.

Related Issue

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

* Fix the inter delay for _Cellular_AtcmdDataSend
@chinglee-iot chinglee-iot requested a review from ActoryOu October 20, 2023 10:26
@chinglee-iot chinglee-iot merged commit ccbd0fc into FreeRTOS:main Oct 23, 2023
10 checks passed
@chinglee-iot chinglee-iot deleted the fix-data-send-inter-delay branch October 23, 2023 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants