bsp: synchronize serial access #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aggarg
reviewed
Jan 5, 2024
aggarg
previously approved these changes
Jan 5, 2024
tony-josi-aws
previously approved these changes
Jan 5, 2024
hugueskamba
changed the title
hugueskamba
force-pushed
the
dev/hugkam01/synchronize_serial_access
branch
3 times, most recently
from
996c25e to
475d98b
Compare
The serial driver is used by multiple tasks and not all tasks use
the Log APIs to send data to the serial driver.
This was causing serial data buffer corruption.
Synchronise the access of the serial driver using mutual exclusion
to make it thread-safe.
This also removes code duplication and fixes return values for
the write system call:
* Arm GNU Toolchain: On failure, `-1`.
On success, total chars written.
* Arm Compiler: On failure, a positive number representing the number of
chars NOT written or a negative number indicating an error.
On success, `0`.
Signed-off-by: Devaraj Ranganna <[email protected]>
Signed-off-by: Hugues Kamba-Mpiana <[email protected]>
hugueskamba
force-pushed
the
dev/hugkam01/synchronize_serial_access
branch
from
475d98b to
71f3225
Compare
hugueskamba
changed the title
kar-rahul-aws
approved these changes
Jan 7, 2024
aggarg
approved these changes
Jan 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The serial driver is used by multiple tasks and not all tasks use the Log APIs to send data to the serial driver.
This was causing serial data buffer corruption.
Synchronise the access of the serial driver using mutual exclusion to make it thread-safe.
This also removes code duplication and fixes return values for
the write system call:
-1.On success, total chars written.
chars NOT written or a negative number indicating an error.
On success,
0.Write system call information:
Test Steps
Checklist:
Related Issue
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.