Update word list #30
Closed
Update word list #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AniruddhaKanhere
approved these changes
Jan 5, 2024
hugueskamba
reviewed
Jan 8, 2024
| @@ -32,10 +32,10 @@ Drbg | |||
| DRBG | |||
There was a problem hiding this comment.
Could you please explain where Unix/GNU Sort is used?
Could you please also explain in the commit message why it was changed.
All I see in this PR is a number of words added to .github/.cSpellWords.txt.
Thanks
hugueskamba
reviewed
Jan 8, 2024
| @@ -6,31 +6,49 @@ ASYM | |||
| BBOOL | |||
| blinky | |||
| Blinky | |||
| cbmc | |||
There was a problem hiding this comment.
Can you please explain in the commit message what prompted the addition of these new words?
hugueskamba
reviewed
Jan 8, 2024
| @@ -32,6 +31,7 @@ CSDK | |||
| CSRS | |||
| ctest | |||
| Customisation | |||
| DCMAKE | |||
There was a problem hiding this comment.
Can you please explain the commit message better as Merge branch 'main' into updateWordList is not very clear why these words are added?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use Unix/GNU Sort instead of MacOS sort. MacOS version of sort will put capital letters at the end, GNU sort does not.
Add new common spelling words to the cSpellWordList to account for the issue mentioned in FreeRTOS/CI-CD-Github-Actions#99
Test Steps
Checklist:
Related Issue
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.