Add freertos_command_pool.c unit tests #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds 7 new unit tests for the file freertos_command_pool.c. Signed-off-by: Reuben Cartwright <[email protected]>
FreeRTOSConfig.h has been corrected to #include "fff.h". Additionally defines configASSERT within FreeRTOS.h. Signed-off-by: Reuben Cartwright <[email protected]>
`mqtt_agent_task.h` included `transport_interface_api.h` unnecessarily for unit testing. This has been extracted into the test file `test_mqtt_agent_task.cpp` instead. Signed-off-by: Reuben Cartwright <[email protected]>
Makes CMakeLists.txt use `BUILD_TESTING` as well as `CMAKE_CROSSCOMPILING`. Signed-off-by: Reuben Cartwright <[email protected]>
This commit adds an explanation in `unit_testing.md` on how configASSERT is handled in `freertos_command_pool.c` tests and other test files. The intended behaviour is that an assertion failure causes the rest of the code to stop running, but can be handled by a test and does not stop the rest of the test's checks running. Signed-off-by: Reuben Cartwright <[email protected]>
urutva
approved these changes
Sep 19, 2024
aggarg
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds 7 new unit tests for the file freertos_command_pool.c.
Ideally, more tests would have been added.
However, due to how the code was written any tests that filled the command pool would require
(a) exposing structures the code is using internally, so would break if this was changed.
(b) large refactoring of the code, adding to it's public interface.
Additionally, this PR fixes some mocks and modifies
test_mqtt_agent_task.cppto match.Test Steps
Checklist:
Related Issue
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.