Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: (Flathub version) removing a video from a playlist then immediately navigating away: video not removed #6934

Open
5 of 6 tasks
mastazi opened this issue Feb 26, 2025 · 8 comments · May be fixed by #7099
Open
5 of 6 tasks

Comments

@mastazi
Copy link

mastazi commented Feb 26, 2025

Guidelines

Describe the bug

  1. Go to a playlist
  2. Remove a video from a playlist by clicking on the rubbish bin icon
  3. Immediately navigate away from the playlist, e.g. by clicking on the Freetube logo at the top of the app
  4. Come back to the playlist by clicking on the "playlists" button on the sidebar, then on the playlist in question
  5. The video is still there

I can reproduce this reliably on Linux Flathub version
I could not reproduce on Mac
I could reproduce only very rarely on Windows

Expected Behavior

At point 5 we should observe that the removed video is no longer part of the playlist

Issue Labels

inconsistent behavior

FreeTube Version

v0.23.2

Operating System Version

Ubuntu 20.04

Installation Method

Flathub

Primary API used

Local API

Last Known Working FreeTube Version (If Any)

No response

Additional Information

No response

Nightly Build

@mastazi mastazi added the bug Something isn't working label Feb 26, 2025
@github-project-automation github-project-automation bot moved this to To assign in Bug Reports Feb 26, 2025
@efb4f5ff-1298-471a-8973-3d47447115dc

Please share a video of this behavior.

@mastazi
Copy link
Author

mastazi commented Feb 27, 2025

Here is the video. I am repeatedly removing the same video from a playlist, and each time I come back to the playlist the video is still there. The only workaround is to wait about 10 seconds before leaving the playlist page. If I leave it sooner than that, the video will be there and I can go on doing what I was doing in the video indefinitely. I was able to do this more than 10 times in a row, didn't capture it on video because it would be boring :-)

screencast-Freetube-bug.mp4

@mastazi
Copy link
Author

mastazi commented Feb 27, 2025

The screencast did not record the mouse pointer so it's a bit hard to follow. Here is what I'm doing:

  1. click on "playlists" on the left sidebar
  2. click on "watch later"
  3. go to the video titled "The Insane Story Behind Kickstart My Heart", click on the rubbish bin icon
  4. click on "Freetube" logo at the top which brings me back to the subscriptions page
  5. rinse and repeat

@absidue
Copy link
Member

absidue commented Feb 27, 2025

The problem is that you are leaving the page before the click to undo popup has disappeared. As actually undoing the operation is a lot more complicated, we instead visually hide the video when you click the remove button and then only actually remove it from the playlist when the toast has disappeared/it is no longer possible for you to click undo. That logic happens on the playlist page, so by leaving the page before the toast has disappeared it never had a chance to actually remove the video.

@efb4f5ff-1298-471a-8973-3d47447115dc

Reproduced on FTA.

Also something to note:

If the user comes back to the playlist fast enough the video will still get removed

screen-20250227-084452.mp4

@mastazi
Copy link
Author

mastazi commented Feb 27, 2025

@absidue Ooooooh I see! Thank you for explaining. Does the toast last the same time on all platforms? For some reason on Mac I couldn’t reproduce. Or maybe I’m just slower on some computers depending on the input device I’m using…

Edit actually I think I’m faster on Mac and as @efb4f5ff-1298-471a-8973-3d47447115dc said I was getting back to the playlist before the toast disappeared. I remember still seeing the video for a fraction of a second then it was gone

@cyberalt1

This comment has been minimized.

@doublecrow
Copy link

I am working on a fix for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: To assign
5 participants