Skip to content
This repository has been archived by the owner on Aug 23, 2020. It is now read-only.

HTTP2/Push not working as expected #28

Open
2 tasks done
the-hotmann opened this issue Nov 6, 2019 · 7 comments
Open
2 tasks done

HTTP2/Push not working as expected #28

the-hotmann opened this issue Nov 6, 2019 · 7 comments

Comments

@the-hotmann
Copy link

the-hotmann commented Nov 6, 2019

Actual behaviour

At the first load (anonym Tab) the .js File gets pushed with HTTP2/Push but the .css File not, also the the second load (hard reload to reload all ressources) no even a single File is getting pushed with HTTP2/Push.
On the same Server a TYPO3 page is hosted and works flawless every time you call the page, no matter what, its pushing the selected Files all the Time, not just at the first call.

Also the .css Files never gets pushed, is there a way to force this plugin to do so?

Expected behaviour

Pushing all Files everytime, on every call

Environment

Debian 9.11
Plesk 18
Shopware 5.6.2

Steps to reproduce

  1. Well srsly xD just install this Plugin and use it, for me its not pushing the needed Files.
  2. if you need more Infos pls comment, and I will provide them.
    I also can provide some screenshots from the Google Chrome DevConsole (Network Section)

Checklist

  • I have checked all issues and haven't found a similar report.
  • I am using the latest stable version of this plugin. (1.1.0)

--

♥ ANY INCOMPLETE REPORT WILL BE CLOSED RIGHT AWAY ♥

@shyim
Copy link
Member

shyim commented Nov 6, 2019

This plugin does nothing on 5.6. This feature is now in core. Have you Link headers?

@the-hotmann
Copy link
Author

Link Headers?
How do I check if I do have this?

@the-hotmann
Copy link
Author

the-hotmann commented Nov 6, 2019

I checked the Response of the html File and the Header, on the first Load there is this Header:

h2-pushed: </web/cache/1573060604_a5ca549df789aefe5cb7ea0c274f6ee5.js>

But when I reload its not there anymore

Also does this Plugin support forcing the compiled/combined CSS File to be pushed?
Makes a lot of sense to me as it gets handled as "inlineCSS" and no renderblocking

@shyim
Copy link
Member

shyim commented Nov 6, 2019

They will be only pushed once. Otherwise, is the performance slower than without

@the-hotmann
Copy link
Author

Dont get this, if you already have the ressources that normaly are pushed then you do not request them again, you just pull them out of the Cache.
Means: if you have to load them again (Force reload) it cant be faster without pushing then with pushing, also the JS and CSS Files are getting 'invoked' at a different time, which leads to inconsistent behaviour.

But again this all is not explaining why it is not pushing the css File!?

@shyim
Copy link
Member

shyim commented Nov 6, 2019

They will be pushed only once, because they are then in the browser cache. Not need to push it on every request. It is slower, cause the response is bigger and the client does not need it, cause its on client cache.
When you push on every request, the chrome developer console will show also a warning 😉

@the-hotmann
Copy link
Author

When you push on every request, the chrome developer console will show also a warning 😉

Never seen a warning in Chrom Dev Console for pushing. Could you pls show me what you mean?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants