Skip to content

Commit 91b60be

Browse files
committed
Less config checks in loop, added newline at EOF
1 parent 69fcc17 commit 91b60be

2 files changed

Lines changed: 5 additions & 3 deletions

File tree

permissions.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,4 +3,4 @@ dynmap.fullrender # Issue a full render
33
dynmap.hide.self # Hide self from map
44
dynmap.hide.others # Hide others from map
55
dynmap.show.self # Reveal self on map
6-
dynmap.show.others # Reveal others on map
6+
dynmap.show.others # Reveal others on map

src/main/java/org/dynmap/PlayerList.java

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -76,9 +76,10 @@ public void setVisible(String playerName, boolean visible) {
7676
public Player[] getVisiblePlayers(String worldName) {
7777
ArrayList<Player> visiblePlayers = new ArrayList<Player>();
7878
Player[] onlinePlayers = server.getOnlinePlayers();
79+
boolean useWhitelist = configuration.getBoolean("display-whitelist", false);
7980
for (int i = 0; i < onlinePlayers.length; i++) {
8081
Player p = onlinePlayers[i];
81-
if (p.getWorld().getName().equals(worldName) && !(configuration.getBoolean("display-whitelist", false) ^ hiddenPlayerNames.contains(p.getName().toLowerCase()))) {
82+
if (p.getWorld().getName().equals(worldName) && !(useWhitelist ^ hiddenPlayerNames.contains(p.getName().toLowerCase()))) {
8283
visiblePlayers.add(p);
8384
}
8485
}
@@ -90,9 +91,10 @@ public Player[] getVisiblePlayers(String worldName) {
9091
public Player[] getVisiblePlayers() {
9192
ArrayList<Player> visiblePlayers = new ArrayList<Player>();
9293
Player[] onlinePlayers = server.getOnlinePlayers();
94+
boolean useWhitelist = configuration.getBoolean("display-whitelist", false);
9395
for (int i = 0; i < onlinePlayers.length; i++) {
9496
Player p = onlinePlayers[i];
95-
if (!(configuration.getBoolean("display-whitelist", false) ^ hiddenPlayerNames.contains(p.getName().toLowerCase()))) {
97+
if (!(useWhitelist ^ hiddenPlayerNames.contains(p.getName().toLowerCase()))) {
9698
visiblePlayers.add(p);
9799
}
98100
}

0 commit comments

Comments
 (0)