Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: dialog z index #472

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: dialog z index #472

wants to merge 1 commit into from

Conversation

helciofranco
Copy link
Member

@helciofranco helciofranco commented Jan 29, 2025 •
edited
Loading

Summary

Removed z-index from modals to ensure stacking follows DOM order, preventing unintended click propagation issues.

Specifically because of how React.Portal and DOM works

Checklist

  • I've added error handling for all actions/requests, and verified how this error will show on UI. (or there was no error handling)
  • I've reviewed all the copy changed/added in this PR, using AI if needed. (or there was no copy changes)
  • I've included the reference to the issues being closed from Github and/or Linear (or there was no issues)
  • I've changed the Docs to reflect my changes (or it was not needed)
  • I've put docs links where it may be helpful (or it was not needed)
  • I checked the resulting UI both in Light and Dark mode (or no UI changes were made)
  • I reviewed the entire PR myself (preferably, on GH UI)

@helciofranco helciofranco self-assigned this Jan 29, 2025
@helciofranco helciofranco linked an issue Jan 29, 2025 that may be closed by this pull request
Fix Dialog z-index #471
Open
@vercel Vercel
Copy link

vercel bot commented Jan 29, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fuel-connectors ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 29, 2025 11:03pm

@helciofranco helciofranco marked this pull request as ready for review January 29, 2025 23:03
@github-actions GitHub Actions
Copy link
Contributor

Coverage Report for Fuel Wallet (./packages/fuel-wallet)

Status Category Percentage Covered / Total
🔵 Lines 61.63% 143 / 232
🔵 Statements 61.63% 143 / 232
🔵 Functions 56.66% 17 / 30
🔵 Branches 86.95% 20 / 23
File CoverageNo changed files found.
Generated in workflow #1379 for commit 9a4e706 by the Vitest Coverage Report Action

@github-actions GitHub Actions
Copy link
Contributor

Coverage Report for Fuel Development Wallet (./packages/fuel-development-wallet)

Status Category Percentage Covered / Total
🔵 Lines 100% 19 / 19
🔵 Statements 100% 19 / 19
🔵 Functions 100% 1 / 1
🔵 Branches 100% 1 / 1
File CoverageNo changed files found.
Generated in workflow #1379 for commit 9a4e706 by the Vitest Coverage Report Action

@github-actions GitHub Actions
Copy link
Contributor

Coverage Report for Fuelet Wallet (./packages/fuelet-wallet)

Status Category Percentage Covered / Total
🔵 Lines 100% 24 / 24
🔵 Statements 100% 24 / 24
🔵 Functions 100% 1 / 1
🔵 Branches 100% 1 / 1
File CoverageNo changed files found.
Generated in workflow #1379 for commit 9a4e706 by the Vitest Coverage Report Action

@helciofranco helciofranco enabled auto-merge (squash) January 29, 2025 23:07
LuizAsFight
LuizAsFight requested changes Jan 29, 2025
View reviewed changes
Copy link
Contributor

@LuizAsFight LuizAsFight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high impact change we should test it very well with a pr version in other projects first

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LuizAsFight LuizAsFight LuizAsFight requested changes

@luizstacio luizstacio Awaiting requested review from luizstacio luizstacio is a code owner

@pedronauck pedronauck Awaiting requested review from pedronauck pedronauck is a code owner

@arthurgeron arthurgeron Awaiting requested review from arthurgeron arthurgeron is a code owner

@rodrigobranas rodrigobranas Awaiting requested review from rodrigobranas rodrigobranas is a code owner

Requested changes must be addressed to merge this pull request.

Assignees

@helciofranco helciofranco

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix Dialog z-index
2 participants
@helciofranco @LuizAsFight