Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid cloning of vectors in HexString #2657

Open
xgreenx opened this issue Feb 1, 2025 · 0 comments
Open

Avoid cloning of vectors in HexString #2657

xgreenx opened this issue Feb 1, 2025 · 0 comments
Labels
good first issue Good for newcomers

Comments

@xgreenx
Copy link
Collaborator

xgreenx commented Feb 1, 2025

The GraphQL server coverts bytes into the hex string to return it to the user. During this convert process, we take vector by value.

Image

We have many cases where we clone vectors instead of passing it as a reference.

This issue is created to replace Vec<u8> with Cow<[u8]> or Cow<Vec<u8>> and allow usage of references.
@xgreenx xgreenx added the good first issue Good for newcomers label Feb 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@xgreenx