Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add minified version in CDN #1728

Closed
arboleya opened this issue Feb 7, 2024 · 3 comments
Closed

Add minified version in CDN #1728

arboleya opened this issue Feb 7, 2024 · 3 comments
Assignees
Labels
feat Issue is a feature

Comments

@arboleya
Copy link
Member

arboleya commented Feb 7, 2024

We should provide a minified version together with the normal one.

This is a follow-up issue on top of:

@arboleya arboleya added the feat Issue is a feature label Feb 7, 2024
@arboleya arboleya added this to the Mainnet milestone Jun 9, 2024
@arboleya arboleya removed the mainnet label Jun 9, 2024
@arboleya arboleya modified the milestones: 0.x mainnet, 0.x post-launch Jun 12, 2024
@petertonysmith94 petertonysmith94 self-assigned this Jul 12, 2024
@arboleya arboleya modified the milestones: 0.x post-launch, 0.x mainnet Jul 13, 2024
@petertonysmith94
Copy link
Contributor

Blocked until release of:

Then:

  • Make to changes CDNJS configuration file (fuels.json):
    {
      ...,
      "autoupdate": {
        "source": "npm",
        "target": "fuels",
        "fileMap": [
          {
            "basePath": "dist",
            "files": ["browser.mjs", "browser.min.mjs"]
          }
        ],
        "ignoreVersions": [
          "0.0.0-*"
        ]
      },
      ...,
    }
    (Add minified bundle (browser.min.mjs) and ignoreVersions)

@petertonysmith94
Copy link
Contributor

PR is in review

@arboleya arboleya removed this from the 0.x mainnet milestone Jul 19, 2024
@arboleya arboleya removed the p0 label Aug 2, 2024
@petertonysmith94
Copy link
Contributor

Will mark this as closed as CDNJS configuration has now been merged:

We should monitor the release of #2863 to ensure the minified version is present.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat Issue is a feature
Projects
None yet
Development

No branches or pull requests

2 participants