Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dependabot script not bumping patch versions in changesets #2594

Closed
maschad opened this issue Jun 24, 2024 · 3 comments · Fixed by #2640
Closed

Dependabot script not bumping patch versions in changesets #2594

maschad opened this issue Jun 24, 2024 · 3 comments · Fixed by #2640
Assignees
@nedsalk
Labels
chore Issue is a chore p1 Medium priority
Milestone
0.x mainnet

Comments

@maschad
Copy link
Member

maschad commented Jun 24, 2024

If a dependency in one of our packages is bumped, the changesets should also bump the patch version of that package.
@maschad maschad self-assigned this Jun 24, 2024
@maschad maschad added the p0 High priority label Jun 24, 2024
@maschad maschad mentioned this issue Jun 24, 2024
Merged
@maschad maschad added chore Issue is a chore p1 Medium priority and removed p0 High priority p1 Medium priority labels Jun 24, 2024
@maschad maschad added this to the 0.x mainnet milestone Jun 24, 2024
@petertonysmith94
Copy link
Contributor

Could we test for templates/nextjs bumping the create-fuels package as well :)

@maschad maschad removed their assignment Jun 24, 2024
@maschad
Copy link
Member Author

maschad commented Jun 24, 2024

Could we test for templates/nextjs bumping the create-fuels package as well :)

Just to clarify, your suggesting that if a dependency is bumped in templates/nextjs then the create-fuels version should be bumped as well?

@petertonysmith94
Copy link
Contributor

Could we test for templates/nextjs bumping the create-fuels package as well :)

Just to clarify, your suggesting that if a dependency is bumped in templates/nextjs then the create-fuels version should be bumped as well?

Correct.

@nedsalk nedsalk self-assigned this Jun 27, 2024
@nedsalk nedsalk mentioned this issue Jun 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nedsalk nedsalk

Labels
chore Issue is a chore p1 Medium priority
Projects
None yet
Milestone
0.x mainnet
Development

Successfully merging a pull request may close this issue.

ci: fix dependabot script not bumping packages in changeset FuelLabs/fuels-ts
3 participants
@maschad @petertonysmith94 @nedsalk