-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Browser tests are inconsistently failing due to dynamic istanbul
import
#2612
Comments
Bumping priority to |
I see that some of the CI jobs are now passing upon re-running the jobs, so the PRs in my description may become outdated. |
The message may be misleading, as the logs the following errors are present: Module "child_process" has been externalized for browser compatibility. Cannot access "child_process.spawn" in client code. See https://vitejs.dev/guide/troubleshooting.html#module-externalized-for-browser-compatibility for more details.
Module "child_process" has been externalized for browser compatibility. Cannot access "child_process.exec" in client code. See https://vitejs.dev/guide/troubleshooting.html#module-externalized-for-browser-compatibility for more details. This appears to have been introduced in the following PR (based upon the CI failures): I can imagine that there is failure path that is causing cc @nedsalk |
Indeed We could try the |
There are a few PRs currently failing on CI due to the failure to dynamically fetch istanbul for code coverage. This doesn't happen consistently though.
Here are a few affected PRs:
The text was updated successfully, but these errors were encountered: