Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export [test] utilities in umbrella package #2223

Open
arboleya opened this issue May 3, 2024 · 1 comment · May be fixed by #2637
Open

Export [test] utilities in umbrella package #2223

arboleya opened this issue May 3, 2024 · 1 comment · May be fixed by #2637
Assignees
Labels
chore Issue is a chore p1 Medium priority
Milestone

Comments

@arboleya
Copy link
Member

arboleya commented May 3, 2024

We should export all secondary entry points (utilities) using dedicated entry points in the fuels umbrella package.

For example:

  • fuels/test-utils — all test utilities from all sub-packages
  • fuels/cli-utils — all CLI utilities from all sub-packages

The idea is that each of these would consolidate all utilities of the same group.

A few examples I grabbed from the codebase:

import { generateTestWallet } from '@fuel-ts/account/test-utils';
import { expectToThrowFuelError } from '@fuel-ts/errors/test-utils';
import { findBinPath } from '@fuel-ts/utils/cli-utils';

The umbrella package should be the only thing users should have to deal with.

@arboleya arboleya added the chore Issue is a chore label May 3, 2024
@nedsalk
Copy link
Contributor

nedsalk commented May 3, 2024

Related comment. That PR has implementation for how the infrastructure part of this issue would be handled.

@arboleya arboleya changed the title Export utilities in umbrella package Export [test] utilities in umbrella package May 31, 2024
@arboleya arboleya added mainnet p0 High priority labels Jun 9, 2024
@arboleya arboleya added this to the Mainnet milestone Jun 9, 2024
@arboleya arboleya added p1 Medium priority and removed mainnet p0 High priority labels Jun 9, 2024
@nedsalk nedsalk self-assigned this Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Issue is a chore p1 Medium priority
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants