fix: ignored subscriptions not being read #3695
Merged
+77
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
nedsalk
changed the title
nedsalk
requested review from
digorithm,
arboleya,
Torres-ssf,
danielbate and
petertonysmith94
as code owners
petertonysmith94
approved these changes
Feb 11, 2025
Torres-ssf
approved these changes
Feb 11, 2025
danielbate
approved these changes
Feb 12, 2025
|
Coverage Report:
Changed Files:
|
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fuel network logs showed some subscriptions weren't being closed and the current hypothesis is that the TS SDK is the culprit because it doesn't automatically read data as it comes from the node but rather waits for the user to start reading it. Even though the fuel-core nodes do close subscriptions once they stream all the data, they still have to wait for ACK messages from the clients and it might be the case that sometimes the clients' TCP receive buffer gets filled up to the point that they stop sending ACK messages to the server (because they don't read the stream), putting the server in a stalemate position until it kills the subscription via timeouts.
The next step would be to integrate the
submitmutation ergonomically viaso that users can decide to not use the subscription if they don't need it.
Checklist