From 62fa558e00c9b3f91c48feed4620ef5d78f4272d Mon Sep 17 00:00:00 2001 From: Peter Smith Date: Wed, 17 Jul 2024 12:17:17 +0100 Subject: [PATCH 1/2] fix: install command for `create-fuels` --- packages/create-fuels/src/cli.ts | 2 +- packages/create-fuels/src/lib/setupProgram.test.ts | 8 ++++++++ packages/create-fuels/src/lib/setupProgram.ts | 4 ++-- 3 files changed, 11 insertions(+), 3 deletions(-) diff --git a/packages/create-fuels/src/cli.ts b/packages/create-fuels/src/cli.ts index 9d4deff828..01ce25ad39 100644 --- a/packages/create-fuels/src/cli.ts +++ b/packages/create-fuels/src/cli.ts @@ -118,7 +118,7 @@ export const runScaffoldCli = async ({ fileCopySpinner.succeed('Copied template files!'); - if (opts['no-install'] === false) { + if (opts.install) { const installDepsSpinner = ora({ text: 'Installing dependencies..', color: 'green', diff --git a/packages/create-fuels/src/lib/setupProgram.test.ts b/packages/create-fuels/src/lib/setupProgram.test.ts index 684b4afc4f..940625f7eb 100644 --- a/packages/create-fuels/src/lib/setupProgram.test.ts +++ b/packages/create-fuels/src/lib/setupProgram.test.ts @@ -11,6 +11,7 @@ describe('setupProgram', () => { expect(program.opts().pnpm).toBe(true); expect(program.opts().npm).toBe(true); expect(program.opts().bun).toBe(true); + expect(program.opts().install).toBe(true); }); test('setupProgram - no args', () => { @@ -19,5 +20,12 @@ describe('setupProgram', () => { expect(program.opts().pnpm).toBe(undefined); expect(program.opts().npm).toBe(undefined); expect(program.opts().bun).toBe(undefined); + expect(program.opts().install).toBe(true); + }); + + test('setupProgram - `--no-install`', () => { + const program = setupProgram(); + program.parse(['', '', 'test-project-name', '--no-install']); + expect(program.opts().install).toBe(false); }); }); diff --git a/packages/create-fuels/src/lib/setupProgram.ts b/packages/create-fuels/src/lib/setupProgram.ts index b244b7d1b6..069d8734ba 100644 --- a/packages/create-fuels/src/lib/setupProgram.ts +++ b/packages/create-fuels/src/lib/setupProgram.ts @@ -10,7 +10,7 @@ export interface ProgramOptions { npm?: boolean; bun?: boolean; verbose?: boolean; - 'no-install'?: boolean; + install?: boolean; } export const setupProgram = () => { @@ -21,7 +21,7 @@ export const setupProgram = () => { .option('--npm', 'Use npm to install dependencies') .option('--bun', 'Use bun to install dependencies') .option('--verbose', 'Enable verbose logging') - .option('--no-install', `Do not install dependencies after scaffolding`, false) + .option('--no-install', 'Do not install dependencies') .addHelpCommand() .showHelpAfterError(true); return program; From 447ff41c2a8486da53907558c032b6ceee367a38 Mon Sep 17 00:00:00 2001 From: Peter Smith Date: Wed, 17 Jul 2024 12:18:21 +0100 Subject: [PATCH 2/2] chore: changeset --- .changeset/rare-ducks-sort.md | 4 ++++ 1 file changed, 4 insertions(+) create mode 100644 .changeset/rare-ducks-sort.md diff --git a/.changeset/rare-ducks-sort.md b/.changeset/rare-ducks-sort.md new file mode 100644 index 0000000000..7820a45317 --- /dev/null +++ b/.changeset/rare-ducks-sort.md @@ -0,0 +1,4 @@ +--- +--- + +fix: `create-fuels` install dependencies by default