Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Approve Screen: Randomly not showing operations #1415

Closed
LuizAsFight opened this issue Jul 11, 2024 · 2 comments
Closed

Approve Screen: Randomly not showing operations #1415

LuizAsFight opened this issue Jul 11, 2024 · 2 comments
Assignees
Labels
bug Something isn't working p0 For yesterday. critical bugs / big priorities

Comments

@LuizAsFight
Copy link
Contributor

LuizAsFight commented Jul 11, 2024

How to reproduce

Try to approve a transaction from a DAPP, for instance https://connectors.fuel.network

Current action

Wallet is sometimes showing the contract call but other times it's not. It's sort of random

Expected action

Wallet should always show the contract call operation

Notes

https://github.com/user-attachments/assets/c9bda804-ca6a-4c0c-9dfc-1ef81fbace1f
I suspect of some things:

  • can it be caused because of a mismatch of versions between SDK of the dapp and connector? for instance the can be using sdk 0.88.1 while the wallet is using 0.86.0. on this way a transaction would be created in sdk 0.88.1, but sent through a sdk 0.86.0 using possibly a different sendTransaction implementation?
  • dryRun returning a different value depending on the contract call. can be something with gasPrice? maxFee? now that gasPrice can change in the network..before we didn't have this factor)
  • some detail in sdk implementation that is not detecting the operations in some specific cases
@LuizAsFight LuizAsFight added bug Something isn't working p0 For yesterday. critical bugs / big priorities labels Jul 11, 2024
@LuizAsFight LuizAsFight added the blocked Blocked by another issue label Jul 15, 2024
@LuizAsFight
Copy link
Contributor Author

blocked by FuelLabs/fuels-ts#2763

@LuizAsFight
Copy link
Contributor Author

LuizAsFight commented Jul 31, 2024

when FuelLabs/fuels-ts#2782 is merged, this issue can be implemented.

we will need to upgrade ts-sdk version as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working p0 For yesterday. critical bugs / big priorities
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants