Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update all deps to be the latest version across the whole repo #6179

Closed
JoshuaBatty opened this issue Jun 24, 2024 · 1 comment · May be fixed by #6190
Closed

Update all deps to be the latest version across the whole repo #6179

JoshuaBatty opened this issue Jun 24, 2024 · 1 comment · May be fixed by #6190
Assignees
@alfiedotwtf
Labels
code quality

Comments

@JoshuaBatty
Copy link
Member

JoshuaBatty commented Jun 24, 2024 •
edited by rvcas
Loading

Also, it might be worth us migrating to defining dependencies used across multiple workspace members in a [workspace.dependencies] section. Eg

[workspace.dependencies]
clap = "4.5"
dashmap = "6.0"

Then in the member projections Cargo.toml we can bring them in like

[dependencies]
clap = { workspace = true }
dashmap = { workspace = true }
@rvcas rvcas mentioned this issue Jun 25, 2024
Draft
8 tasks
@JoshuaBatty JoshuaBatty assigned alfiedotwtf and unassigned rvcas Aug 16, 2024
alfiedotwtf added a commit that referenced this issue Sep 5, 2024
@alfiedotwtf
Add the workspace version to the root Cargo.toml (#6179)
8f3e608
@alfiedotwtf alfiedotwtf mentioned this issue Sep 5, 2024
Closed
alfiedotwtf added a commit that referenced this issue Sep 5, 2024
@alfiedotwtf
Replace cargo deps with build-in cargo tree (#6179)
33810ae 
- cargo-deps is no longer maintained
- cargo-deps doesn't understand workspaces
alfiedotwtf added a commit that referenced this issue Sep 6, 2024
@alfiedotwtf
Add the workspace version to the root Cargo.toml (#6179)
d4d5c44
alfiedotwtf added a commit that referenced this issue Sep 6, 2024
@alfiedotwtf
Replace cargo deps with build-in cargo tree (#6179)
62d047f 
- cargo-deps is no longer maintained
- cargo-deps doesn't understand workspaces
alfiedotwtf added a commit that referenced this issue Sep 6, 2024
@alfiedotwtf
Bump workspace to v0.63.4 (#6179)
7376b1e
alfiedotwtf added a commit that referenced this issue Sep 6, 2024
@alfiedotwtf
Move all external dependencies to the workspace (#6179)
df80209
alfiedotwtf added a commit that referenced this issue Sep 6, 2024
@alfiedotwtf
Clean up single attributed dependencies (#6179)
c1d2db3
alfiedotwtf added a commit that referenced this issue Sep 6, 2024
@alfiedotwtf
Fix Cargo dependency sort order (#6179)
bf22cfa
alfiedotwtf added a commit that referenced this issue Sep 6, 2024
@alfiedotwtf
Revert non-workspace Cargo.toml (#6179)
ba0e9d3
alfiedotwtf added a commit that referenced this issue Sep 6, 2024
@alfiedotwtf
Fix Cargo dependency sort order (#6179)
1a2a440
alfiedotwtf added a commit that referenced this issue Sep 6, 2024
@alfiedotwtf
Revert non-workspace Cargo.toml (#6179)
ff3c935
alfiedotwtf added a commit that referenced this issue Sep 9, 2024
@alfiedotwtf
Add the workspace version to the root Cargo.toml (#6179)
64588a3
alfiedotwtf added a commit that referenced this issue Sep 9, 2024
@alfiedotwtf
Replace cargo deps with build-in cargo tree (#6179)
6eefe2e 
- cargo-deps is no longer maintained
- cargo-deps doesn't understand workspaces
alfiedotwtf added a commit that referenced this issue Sep 9, 2024
@alfiedotwtf
Bump workspace to v0.63.4 (#6179)
a3f8ded
alfiedotwtf added a commit that referenced this issue Sep 9, 2024
@alfiedotwtf
Move all external dependencies to the workspace (#6179)
6ff4130
alfiedotwtf added a commit that referenced this issue Sep 9, 2024
@alfiedotwtf
Clean up single attributed dependencies (#6179)
f3c3a5f
alfiedotwtf added a commit that referenced this issue Sep 9, 2024
@alfiedotwtf
Fix Cargo dependency sort order (#6179)
75ae8f6
alfiedotwtf added a commit that referenced this issue Sep 9, 2024
@alfiedotwtf
Revert non-workspace Cargo.toml (#6179)
6ba80ff
alfiedotwtf added a commit that referenced this issue Sep 9, 2024
@alfiedotwtf
Dependency features removed from the workspace Cargo.toml (#6179)
713d02f
alfiedotwtf added a commit that referenced this issue Sep 9, 2024
@alfiedotwtf
More single attributed dependency cleanup (#6179)
18d2083
alfiedotwtf added a commit that referenced this issue Sep 9, 2024
@alfiedotwtf
Bump workspace to v0.63.5 (#6179)
cb684bf
alfiedotwtf added a commit that referenced this issue Sep 9, 2024
@alfiedotwtf
Replace cargo deps with build-in cargo tree (#6179)
49b6641 
- cargo-deps is no longer maintained
- cargo-deps doesn't understand workspaces
@alfiedotwtf alfiedotwtf mentioned this issue Sep 9, 2024
Merged
8 tasks
alfiedotwtf added a commit that referenced this issue Sep 9, 2024
@alfiedotwtf
Replace cargo-deps with build-in cargo tree (#6179)
82df7f1 
- cargo-deps is no longer maintained
- cargo-deps doesn't understand workspaces
alfiedotwtf added a commit that referenced this issue Sep 19, 2024
@alfiedotwtf
Fix CI by using the full SemVer value for fuel-core-client (#6179)
9271469
alfiedotwtf added a commit that referenced this issue Sep 19, 2024
@alfiedotwtf
Version bump all crate dependencies that require no code changes (#6179)
8f81597
alfiedotwtf added a commit that referenced this issue Sep 19, 2024
@alfiedotwtf
Move all crate dependencies to the workspace Cargo.toml (#6179)
6402e4b
alfiedotwtf added a commit that referenced this issue Sep 19, 2024
@alfiedotwtf
Fix CI by using the full SemVer value for fuel-core-client (#6179)
757580c
alfiedotwtf added a commit that referenced this issue Sep 19, 2024
@alfiedotwtf
Version bump all crate dependencies that require no code changes (#6179)
98d59a2
alfiedotwtf added a commit that referenced this issue Sep 19, 2024
@alfiedotwtf
Move all crate dependencies to the workspace Cargo.toml (#6179)
a127370
alfiedotwtf added a commit that referenced this issue Sep 19, 2024
@alfiedotwtf
Fix CI by using the full SemVer value for fuel-core-client (#6179)
1b96c15
alfiedotwtf added a commit that referenced this issue Sep 19, 2024
@alfiedotwtf
Version bump all crate dependencies that require no code changes (#6179)
b9674bd
alfiedotwtf added a commit that referenced this issue Sep 19, 2024
@alfiedotwtf
Version bump all crate dependencies that require no code changes (#6179)
4f5d136
alfiedotwtf added a commit that referenced this issue Sep 19, 2024
@alfiedotwtf
Version bump all crate dependencies that require no code changes (#6179)
57902d9
alfiedotwtf added a commit that referenced this issue Sep 20, 2024
@alfiedotwtf
Move all crate dependencies to the workspace Cargo.toml (#6179)
0903dcd
alfiedotwtf added a commit that referenced this issue Sep 20, 2024
@alfiedotwtf
Fix CI by using the full SemVer value for fuel-core-client (#6179)
3913b8f
alfiedotwtf added a commit that referenced this issue Sep 20, 2024
@alfiedotwtf
Version bump all crate dependencies that require no code changes (#6179)
0f9644c
JoshuaBatty pushed a commit that referenced this issue Sep 20, 2024
@alfiedotwtf
Move all crate dependencies to the workspace Cargo.toml (#6179) (#6563)
ab1e030 
## Description

For #6179, PR #6501 kept bumping into errors as it was doing too many
things, so I've split that PR into multiple PRs. This is the first, and
the only thing it does is move all of the various `Cargo.toml`
dependencies into the single workspace `Cargo.toml`.

Future PRs will:
- Update dependency versions
- Update code that breaks from the version bumps

## Checklist

- [x] I have linked to any relevant issues.
- [x] I have commented my code, particularly in hard-to-understand
areas.
- [x] I have updated the documentation where relevant (API docs, the
reference, and the Sway book).
- [x] If my change requires substantial documentation changes, I have
[requested support from the DevRel
team](https://github.com/FuelLabs/devrel-requests/issues/new/choose)
- [x] I have added tests that prove my fix is effective or that my
feature works.
- [x] I have added (or requested a maintainer to add) the necessary
`Breaking*` or `New Feature` labels where relevant.
- [x] I have done my best to ensure that my PR adheres to [the Fuel Labs
Code Review
Standards](https://github.com/FuelLabs/rfcs/blob/master/text/code-standards/external-contributors.md).
- [x] I have requested a review from the relevant team or maintainers.
alfiedotwtf added a commit that referenced this issue Sep 21, 2024
@alfiedotwtf
Version bump all crate dependencies that require no code changes (#6179)
522cbfa
JoshuaBatty added a commit that referenced this issue Sep 21, 2024
@alfiedotwtf @JoshuaBatty
Version bump all crate dependencies after the workspace move (#6571)
1d50da1 
## Description

This is a continuation of #6179, and follows on from PR #6501. These are
broken into separate PRs so that we can discuss each PR `HEAD`
separately so that the PRs that can get merged, do so quickly.
Otherwise, the further along they get stale the more work they all need
in order to keep up to `master` without being hard to find which change
introduced a possible broken build.

This PR only does a version bump to every crate dependency that does not
need any code changes to apply cleanly.

Following this PR will be a new PR, where every commit updates a single
crate along with the files that were needed to be changed in order to
work again. The crates that will need code changes are:

- tokio 1.12: -> 1.40
- rustc-hash: 1.1 -> 2.0
- miden-core: 0.3 -> 0.10
- notify: 5.0 -> 6.1
- notify-debouncer-mini: 0.2 -> 0.4
- revm: 2.3 -> 14.0
- syn: 1.0 -> 2.0
- tikv-jemallocator: 0.5 -> 0.6
- toml_edit: 0.21 -> 0.22

There should also be a commit to upgrade Rust itself to >= `1.81.0`.

... and for another day, there's 3 crates that will take a bit of time
to get working, and so will go under a different issue #6536:

- annotate-snippets
- lsp-types
- uint

## Checklist

- [x] I have linked to any relevant issues.
- [x] I have commented my code, particularly in hard-to-understand
areas.
- [x] I have updated the documentation where relevant (API docs, the
reference, and the Sway book).
- [x] If my change requires substantial documentation changes, I have
[requested support from the DevRel
team](https://github.com/FuelLabs/devrel-requests/issues/new/choose)
- [x] I have added tests that prove my fix is effective or that my
feature works.
- [x] I have added (or requested a maintainer to add) the necessary
`Breaking*` or `New Feature` labels where relevant.
- [x] I have done my best to ensure that my PR adheres to [the Fuel Labs
Code Review
Standards](https://github.com/FuelLabs/rfcs/blob/master/text/code-standards/external-contributors.md).
- [x] I have requested a review from the relevant team or maintainers.

Co-authored-by: Joshua Batty <[email protected]>
alfiedotwtf added a commit that referenced this issue Sep 22, 2024
@alfiedotwtf
Version bump to 0.22 and fixes for toml_edit (#6179)
c69fc4c
alfiedotwtf added a commit that referenced this issue Sep 22, 2024
@alfiedotwtf
Version bump and fixes for notify (6.1) and notify-debouncer-mini (0.…
aa47213 
…4) (#6179)
alfiedotwtf added a commit that referenced this issue Sep 22, 2024
@alfiedotwtf
Version bump to 0.6 for tikv-jemallocator (#6179)
2a7f1d9
alfiedotwtf added a commit that referenced this issue Sep 22, 2024
@alfiedotwtf
Version bump to 14.0 and fixes for revm (#6179)
805fc5f
alfiedotwtf added a commit that referenced this issue Sep 22, 2024
@alfiedotwtf
Version bump to 2.0 and fixes for syn (#6179)
5837851
@alfiedotwtf alfiedotwtf mentioned this issue Sep 22, 2024
Merged
8 tasks
alfiedotwtf added a commit that referenced this issue Sep 23, 2024
@alfiedotwtf
Version bump to 0.22 and fixes for toml_edit (#6179)
fd53e45
alfiedotwtf added a commit that referenced this issue Sep 23, 2024
@alfiedotwtf
Version bump and fixes for notify (6.1) and notify-debouncer-mini (0.…
b94e521 
…4) (#6179)
alfiedotwtf added a commit that referenced this issue Sep 23, 2024
@alfiedotwtf
Version bump to 0.6 for tikv-jemallocator (#6179)
d43e972
alfiedotwtf added a commit that referenced this issue Sep 23, 2024
@alfiedotwtf
Version bump to 14.0 and fixes for revm (#6179)
fb74ef4
alfiedotwtf added a commit that referenced this issue Sep 23, 2024
@alfiedotwtf
Version bump to 2.0 and fixes for syn (#6179)
e1ee3ae
IGI-111 pushed a commit that referenced this issue Sep 23, 2024
@alfiedotwtf
Version bump the remaining crate dependencies (#6579)
e1546f6 
## Description

As part of #6179, this PR updates the remaining quick-fix crates to
their latest X.Y versions. Code fixes were needed to get compilation
working and tests passing.

Issue #6536 lists the crates that will need a bit more work to get
working and passing.

## Checklist

- [x] I have linked to any relevant issues.
- [x] I have commented my code, particularly in hard-to-understand
areas.
- [x] I have updated the documentation where relevant (API docs, the
reference, and the Sway book).
- [x] If my change requires substantial documentation changes, I have
[requested support from the DevRel
team](https://github.com/FuelLabs/devrel-requests/issues/new/choose)
- [x] I have added tests that prove my fix is effective or that my
feature works.
- [x] I have added (or requested a maintainer to add) the necessary
`Breaking*` or `New Feature` labels where relevant.
- [x] I have done my best to ensure that my PR adheres to [the Fuel Labs
Code Review
Standards](https://github.com/FuelLabs/rfcs/blob/master/text/code-standards/external-contributors.md).
- [x] I have requested a review from the relevant team or maintainers.
@alfiedotwtf
Copy link
Contributor

Most dependencies have now been updated. What's left have been moved into #6536

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alfiedotwtf alfiedotwtf

Labels
code quality
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

update all the deps FuelLabs/sway
3 participants
@alfiedotwtf @JoshuaBatty @rvcas