Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Eliminate CompileError::ContractIdConstantNotAConstDecl #6841

Open
jjcnn opened this issue Jan 17, 2025 · 1 comment · May be fixed by #6842
Open

Eliminate CompileError::ContractIdConstantNotAConstDecl #6841

jjcnn opened this issue Jan 17, 2025 · 1 comment · May be fixed by #6842
Labels
compiler: frontend Everything to do with type checking, control flow analysis, and everything between parsing and IRgen good first issue Good for newcomers

Comments

@jjcnn
Copy link
Contributor

jjcnn commented Jan 17, 2025

The error CompileError::ContractIdConstantNotAConstDecl is only used in contract_helpers.rs, and is only thrown if the typecheck of the CONTRACT_ID declaration fails. Since this declaration is generated by the compiler, this typecheck should never fail, and if it does it should be an internal compiler error instead.
@jjcnn jjcnn added compiler: frontend Everything to do with type checking, control flow analysis, and everything between parsing and IRgen good first issue Good for newcomers labels Jan 17, 2025
@mo-hak mo-hak linked a pull request Jan 18, 2025 that will close this issue
Open
8 tasks
@mo-hak
Copy link

mo-hak commented Jan 18, 2025

@jjcnn Please check the PR, and let me know if any changes required !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
compiler: frontend Everything to do with type checking, control flow analysis, and everything between parsing and IRgen good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

CompileError::ContractIdConstantNotAConstDecl mo-hak/sway
2 participants
@jjcnn @mo-hak