forc-pkg: package name and external library alias may not clash

[jjcnn]

The compiler gets confused when the alias of a dependency is the same as the name of the package:

[project]
authors = ["Fuel Labs <[email protected]>"]
entry = "main.sw"
license = "Apache-2.0"
name = "lib_contract"

[dependencies]
lib_contract = { path = "../lib_contract_abi/", package = "lib_contract_abi" }

forc-pkg should throw an error in this situation, but it doesn't.

[kayagokalp]

[project]
authors = ["Fuel Labs <[email protected]>"]
entry = "main.sw"
license = "Apache-2.0"
name = "lib_contract_abi"

[dependencies]
lib_contract = { path = "../lib_contract_abi/", package = "lib_contract_abi" }

Should we also disallow situations where package alias is colliding with package name as well?

[jjcnn]

Should we also disallow situations where package alias is colliding with package name as well?

That situation is currently caught by the compiler, but I think it would be better if forc-pkg did it.