CLI Fixes #322
Merged
CLI Fixes #322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
whitead
commented
Sep 8, 2024
•
whitead
commented
- modify/saving settings
- asking queries
- building indexes
- search answer index
- searching other index
|
Finished writing the tests - they fail 👍 |
|
Hey @mskarlin - I cannot fix the last unit test. It seems to rely on some JSON file being present, but none are being saved to the index. I cannot understand the logic of them being saved in some cases and not in others. I'm hoping you have some knowledge of this. pytest tests/test_cli.py -k build will run the test |
…tter robust to having a Doc object, condition index type on being an "answers" index
jamesbraza
approved these changes
Sep 9, 2024
jamesbraza
reviewed
Sep 9, 2024
| @@ -115,7 +116,7 @@ async def query(self, query: dict) -> DocDetails | None: | |||
| f"{client_query.doi if isinstance(client_query, DOIQuery) else client_query.title}" | |||
| f" in {self.__class__.__name__}." | |||
| ) | |||
| except TimeoutError: | |||
| except (TimeoutError, asyncio.exceptions.TimeoutError): | |||
There was a problem hiding this comment.
Can you add a comment here saying after Python>=3.11 TimeoutError replaces asyncio.exceptions.TimeoutError
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.