Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test speed ups #345

Closed
wants to merge 20 commits into from
Closed

Test speed ups #345

wants to merge 20 commits into from

Conversation

mskarlin
Copy link
Collaborator

@mskarlin mskarlin commented Sep 9, 2024

First I'm tying DNS caching to see if it's a DNS issue.

@whitead
Copy link
Collaborator

whitead commented Sep 10, 2024

An improvement - but it's not using the cassette (?)

@whitead
Copy link
Collaborator

whitead commented Sep 10, 2024

Hey @mskarlin - tried a few variants. 21d703f uses python from a uv venv, same poor performance (canceled after 10 minutes) and 0c7c64f uses actions/setup-python and gets same poor performance. Only other python to try I guess would be system python, but it's 3.10 on our runners. Not sure what else to try?

@mskarlin
Copy link
Collaborator Author

mskarlin commented Sep 10, 2024

Yea we can just build the requirements.txt via uv export then use the system python & upgrade it like:

      - name: Set up Python ${{ matrix.python-version }}
        uses: actions/setup-python@v5
        with:
          python-version: ${{ matrix.python-version }}
          cache: pip
      - run: pip install .

Then the system python would be what we use. We can return to using uv for tests after we figure this out.

@whitead
Copy link
Collaborator

whitead commented Sep 10, 2024

Yea we can just build the requirements.txt via uv export then use the system python & upgrade it like:

      - name: Set up Python ${{ matrix.python-version }}
        uses: actions/setup-python@v5
        with:
          python-version: ${{ matrix.python-version }}
          cache: pip
      - run: pip install .

Then the system python would be what we use. We can return to using uv for tests after we figure this out.

That's pretty much 0c7c64f - except uv did the pip install.

I tried to not use uv for doing the pip install, but that's not compatible with our pyproject.toml. I think it's pretty unlikely that installing system packages with uv would impact performance - but we can try locally committing a requirements I guess

@whitead
Copy link
Collaborator

whitead commented Sep 10, 2024

Ok @mskarlin - I completely purged uv so it's not used for parsing toml file, for pip install, or for python management. Completely clean in b2c1e33. We'll see how long the tests take. Edit: I've determined uv has no effect

@mskarlin mskarlin closed this Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants