-
Notifications
You must be signed in to change notification settings - Fork 553
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added account for cost info #360
Changes from 1 commit
f4d13ba
95e46f6
349f1be
d2ef5e5
0dbcc49
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -239,6 +239,12 @@ class AgentSettings(BaseModel): | |
default="gpt-4o-2024-08-06", | ||
description="Model to use for agent", | ||
) | ||
|
||
agent_llm_config: dict | None = Field( | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. A few lines below this there is an Do you mind adjusting their names and/or descriptions so it's clear what is the difference between There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 👍 Tried to make the descriptions more clear in distinction There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Thanks for your efforts! Being honest, it's still not quite intuitive enough for my tastes, but for now it's good. I think we can make this clearer by moving |
||
default=None, | ||
description="Extra kwargs to pass to agent LLM model", | ||
) | ||
|
||
agent_type: str = Field( | ||
default="fake", | ||
description="Type of agent to use", | ||
|
@@ -500,6 +506,13 @@ def get_summary_llm(self) -> LiteLLMModel: | |
or self._default_litellm_router_settings(self.summary_llm), | ||
) | ||
|
||
def get_agent_llm(self) -> LiteLLMModel: | ||
return LiteLLMModel( | ||
name=self.agent.agent_llm, | ||
config=self.agent.agent_llm_config | ||
or self._default_litellm_router_settings(self.agent.agent_llm), | ||
) | ||
|
||
def get_embedding_model(self) -> EmbeddingModel: | ||
return embedding_model_factory(self.embedding, **(self.embedding_config or {})) | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's just one action