Fixed extra noise in logs from litellm routers #363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whitead
changed the title
jamesbraza
reviewed
Sep 11, 2024
| @@ -23,7 +23,7 @@ dependencies = [ | |||
| "fhaviary[llm]>=0.6", # For info on Message | |||
| "html2text", # TODO: evaluate moving to an opt-in dependency | |||
| "httpx", | |||
| "litellm", | |||
| "litellm>=1.44", # to prevent sys.stdout on router creation | |||
There was a problem hiding this comment.
Our internal envs pins an incompatible range with this, fyi. Maybe we should move the internal one to use LiteLLM router and/or not Anthropic in CI
There was a problem hiding this comment.
Ok - I tried to see if there was a compatible version with both - but there's none.
There was a problem hiding this comment.
I wonder if we can pin litellm this way in just dev dependencies.
Do you think the verbose logs you're hitting impact all users (so we want to pin in core deps), or just your machine for development?
mskarlin
approved these changes
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finally figured it out!