Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More digits on cost #364

Merged
merged 1 commit into from
Sep 11, 2024
Merged

More digits on cost #364

merged 1 commit into from
Sep 11, 2024

Conversation

whitead
Copy link
Collaborator

@whitead whitead commented Sep 11, 2024

Increased resolution on cost. As models have gotten cheaper, it's actually hard to see changes sometimes.

Copy link
Collaborator

@jamesbraza jamesbraza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just check the regex 101 for parsing status will still work with this

@whitead
Copy link
Collaborator Author

whitead commented Sep 11, 2024

Hey @jamesbraza - we couldn't find any regex relying on cost format. If you can recall where that is, yea I can update. Thanks for flagging!

@whitead whitead merged commit 573c97b into september-2024-release Sep 11, 2024
3 checks passed
@whitead whitead deleted the more-cost-status branch September 11, 2024 15:28
@jamesbraza
Copy link
Collaborator

Hey @jamesbraza - we couldn't find any regex relying on cost format. If you can recall where that is, yea I can update. Thanks for flagging!

Yeah sorry I sent that comment from my mobile last night while unable to sleep.

I realized today that actually cost is not part of the regex:

STATUS_SEARCH_REGEX_PATTERN: ClassVar[str] = (
r"Status: Paper Count=(\d+) \| Relevant Papers=(\d+) \| Current Evidence=(\d+)"
)

So we are good 👌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants