Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Size of preview camera #19

Closed
satriawarn opened this issue Sep 9, 2021 · 5 comments
Closed

Size of preview camera #19

satriawarn opened this issue Sep 9, 2021 · 5 comments
Labels
improvement New feature or request

Comments

@satriawarn
Copy link

Hi, it's not issue. I'm wondering how to change the square in preview camera to rectangle, or just dynamic size.

Thank you

@G00fY2 G00fY2 added the improvement New feature or request label Sep 9, 2021
@G00fY2
Copy link
Owner

G00fY2 commented Sep 9, 2021

Hi @satriawarn, you would like to change the corner radius and the generell size of the scanner overlay frame?

You should be aware that due to limitations of ML Kit currently the whole image gets scanned, so the frame is just a visual decoration (#18). Currently the corner radius is taken form Android AOSP scanner, so it matches Googles Design Guidelines. The size is dynamically calculated (it always takes 3/4 of the screen width). I made sure it also looks good on tablet and other devices sizes.

Maybe you could specify what your final design should look like. :)

@satriawarn
Copy link
Author

Like this, I hope it's explain

image

@G00fY2
Copy link
Owner

G00fY2 commented Sep 9, 2021

Okay, that makes it clear. I understand that this layout fit's better for traditional Code128 barcodes.

Will see if I find some time to make the shape customizable. Thanks for sharing your feature request!

@satriawarn
Copy link
Author

I appreciate it, hope it doesn't bother you.

Thanks :)

@G00fY2
Copy link
Owner

G00fY2 commented Oct 25, 2021

I added the option setHorizontalFrameRatio. So this is fixed with 1.3.0/1.3.1.

@G00fY2 G00fY2 closed this as completed Oct 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants