Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trying to be more "Agile"? #17

Open
G0maa opened this issue Dec 21, 2022 · 4 comments
Open

Trying to be more "Agile"? #17

G0maa opened this issue Dec 21, 2022 · 4 comments
Assignees
@G0maa
Labels
enhancement New feature or request

Comments

@G0maa
Copy link
Owner

G0maa commented Dec 21, 2022

These are some notes taken from reading Martin Fowler's "Is Design Dead?" article:
https://www.martinfowler.com/articles/designDead.html
(To add more resources/articles?)

NO DUPLICATION.
YAGNI.
DRY.
  • I would say current goal is to generally do the "enabling practices" of Extreme Programming, which are (as mentioned in the article):
    • (Automated) Testing
    • Continuous Integration
    • Refactoring
    • Simple Design
  • Many of said things are very subjective.
  • tl;dr To-Do & Keep an eye on these four things.
  • About Simple Design:
    • Runs all tests,
    • No duplication,
    • ?Reveals all intention?
    • Fewest number of classes or methods,
@G0maa G0maa added the enhancement New feature or request label Dec 21, 2022
@G0maa G0maa self-assigned this Dec 21, 2022
@G0maa G0maa pinned this issue Dec 21, 2022
@G0maa
Copy link
Owner Author

G0maa commented Dec 23, 2022 •
edited

How I notice possible WET code? => ez pz just comment on it with #17,
which is the number of this issue.😬

G0maa added a commit that referenced this issue Dec 23, 2022
@G0maa
feat: Making Jest set & reset DB in testing iterations
d617705 
- Also relates to #17
- and will benefit #5
@G0maa
Copy link
Owner Author

G0maa commented Dec 24, 2022

CRUD logic is very duplicate(able).

@G0maa
Copy link
Owner Author

G0maa commented Dec 28, 2022 •
edited

  • Adding a "services" layer, would indeed ?greatly? summarize most of the code I wrote? #user
  • Looks like the only thing I'm doing is refactoring without simple design.... 🤦🏻‍♂️🤦🏻‍♂️
  • Edit: See Redirecting everything to user #29

G0maa added a commit that referenced this issue Jan 25, 2023
@G0maa
refactor: CRUD is now in user service only
576c72f 
- Many issues this is related to:
- #13
- #32 , partially, still testing.
- #29 & #17
@G0maa G0maa mentioned this issue Jan 25, 2023
Merged
G0maa added a commit that referenced this issue Jan 25, 2023
@G0maa
Merge pull request #43 from G0maa/changeability
11390fa 
- This PR solves #13 and #29 
- It also relates partially to:
  - #32 
  - #17
@G0maa
Copy link
Owner Author

G0maa commented Jan 25, 2023

  • Thinking of refactoring to OOP, instead of the current imperative style.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@G0maa G0maa

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@G0maa