Separate input validation from database query

[G0maa]

• As suggested by @Amr2812, and @b-fuze.
• Results in: Better Separation of Concerns & more Clean Code.
• Reference:

  • my-school-server/src/validator/general.validator.ts

    Lines 21 to 24 in a8971d8

    	export const ToLikeQuery = (attribute: string | undefined) => {
    	if (!attribute) return;
    	return { [Op.like]: `%${attribute}%` };
    	};

  • my-school-server/src/validator/student.validator.ts

    Lines 18 to 30 in a8971d8

    	export const ZStudentQuery = ZStudent.partial()
    	.extend({
    	classId: ZStudent.shape.classId.transform((attribute) =>
    	ToLikeQuery(attribute)
    	), // duplicate use Z
    	parentName: ZStudent.shape.parentName.transform((attribute) =>
    	ToLikeQuery(attribute)
    	),
    	parentPhonenumber: ZStudent.shape.parentPhonenumber.transform((attribute) =>
    	ToLikeQuery(attribute)
    	),
    	})
    	.partial();

[G0maa]

• API Paging #50 Solves this ever lasting issue, but as advised by @Amr2812, my solution is a hacky one and it will eventually bite me (again), a better solution would be hardcoding the parameters to be querified.

[G0maa]

Solution as of now:

my-school-server/src/utils/helpers.ts

Lines 69 to 102 in 72978e8

	// This is a hakcky solution as told by @Amr2812,
	// and eventually it's gonna bite me, the "better" way
	// is to make a "mapping" function (i.e. from field to querified field),
	// for each schema.
	// P.S: This function sometimes gets input that does not match the schema,
	// i.e. mainly missing page & size.
	const querifyStringFields = (
	object: Record<string, unknown>,
	// eslint-disable-next-line @typescript-eslint/no-explicit-any
	schema: z.ZodObject<any, any>
	) => {
	// console.log('schema.shape', schema.shape);
	for (const key in schema.shape) {
	// for ... in loops over everything,
	// this if condition is to make sure it only loops over the attributes only.
	// eslint-disable-next-line @typescript-eslint/no-unsafe-call, no-prototype-builtins
	if (!schema.shape.hasOwnProperty(key)) continue;
	// Just making sure key exists in the object, might be optional.
	if (object[key] === undefined) continue;
	// eslint-disable-next-line @typescript-eslint/no-unsafe-assignment
	const field = schema.shape[key];
	// For ZodOptional<ZodString> and similar cases.
	// eslint-disable-next-line @typescript-eslint/no-unsafe-assignment, @typescript-eslint/no-unsafe-argument
	const typeName = mostInnerType(field);
	// eslint-disable-next-line @typescript-eslint/no-unsafe-member-access
	if (typeName === 'ZodString')
	object[key] = { [Op.like]: `%${object[key]}%` };
	}
	return object;
	};