From 4e0e6fc4ecce6c2f2ff21af74f0167a020981ebe Mon Sep 17 00:00:00 2001 From: TrellixVulnTeam Date: Thu, 3 Nov 2022 13:06:56 +0000 Subject: [PATCH] Adding tarfile member sanitization to extractall() --- science.py | 21 ++++++++++++++++++++- 1 file changed, 20 insertions(+), 1 deletion(-) diff --git a/science.py b/science.py index 3283335..350fe42 100644 --- a/science.py +++ b/science.py @@ -41,7 +41,26 @@ raise else: with tarfile.open("benchmarks.tar.gz") as tar: - tar.extractall() + def is_within_directory(directory, target): + + abs_directory = os.path.abspath(directory) + abs_target = os.path.abspath(target) + + prefix = os.path.commonprefix([abs_directory, abs_target]) + + return prefix == abs_directory + + def safe_extract(tar, path=".", members=None, *, numeric_owner=False): + + for member in tar.getmembers(): + member_path = os.path.join(path, member.name) + if not is_within_directory(path, member_path): + raise Exception("Attempted Path Traversal in Tar File") + + tar.extractall(path, members, numeric_owner=numeric_owner) + + + safe_extract(tar) # Load the benchmarks. results = []