-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Pangea4 host configs #3081
Add Pangea4 host configs #3081
Conversation
set( COMMON_FLAGS "-O3 -march=native -mtune=native" ) | ||
set( RELEASE_FLAGS "-DNDEBUG" ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do you need those explicit flags? I thought that -O3
was already enabled.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this update. Now, I can successfully compile TPLs and GEOS with hpcx-ompi, which is being used to run SEAM cases on P4. However, encountered some troubles on compilation with openmpi.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems good to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! I've successfully compiled GEOS with the default one and completed multiple SEAM cases on P4.
# SCIENTIFIC LIBRARIES | ||
####################################### | ||
|
||
set( ENABLE_FESAPI ON CACHE BOOL "" FORCE ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can remove ENABLE_FESAPI #2969
deb1137
to
d168523
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #3081 +/- ##
===========================================
+ Coverage 53.74% 53.78% +0.04%
===========================================
Files 1016 1016
Lines 85756 85826 +70
===========================================
+ Hits 46092 46165 +73
+ Misses 39664 39661 -3 ☔ View full report in Codecov by Sentry. |
use GCC, OpenMPI and oneAPI MKL
use GCC, HPC-X OpenMPI and oneAPI MKL
d168523
to
14825a8
Compare
will run integrated tests just before merge (as no rebase line is required) |
Adds the Pangea 4 host config files :
Linked to TPLs' PR #262.