Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] POS users #369

Open
SuperVK opened this issue Oct 16, 2024 · 2 comments
Open

[Feature] POS users #369

SuperVK opened this issue Oct 16, 2024 · 2 comments

Comments

@SuperVK
Copy link
Member

SuperVK commented Oct 16, 2024

Is this a feature for the SudoSOS point of sale or for the SudoSOS dashboard?

Point of sale

What would you like?

We should implement the POS user authentication from GEWIS/sudosos-backend#62. As also described in GEWIS/sudosos-backend#232.

This means the flow should be as follows:
After loading the pos website, you are prompted with the same login as the dashboard. After logging in with your user account, you can log into one of the POS'es you own. Receiving a token for the POS that you just logged into. After logging into a POS, the normal keypad appears. Now product queries, and user queries should be made with the POS token, and the transaction should be made with the user token after the using the pin code.

Why is this needed?

Because then every user cannot get every other user anymore, and admins can no longer make admin request with their pin code, making the system more secure.

Other information

We should probably take the login screen logic away from the dashboard, and put this in some sort of common place.

@JustSamuel
Copy link
Contributor

One of the ideas that I had to prevent people having to enter their AD passwords would be a QR-code flow with a callback?

@SuperVK
Copy link
Member Author

SuperVK commented Oct 17, 2024

yeah would be more ideal, but requires some more thought on the backend, so maybe a QoL for later?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants