Coins can't be activated in WASM if `enable_spv_proof` is true

[sergeyboyko0791]

Almost all UTXO coins has enable_spv_proof: true flag in coins config by default.

[sergeyboyko0791]

@tonymorony @anarkiVan we should probably remove this flag from the coins repo at all for air_dex

[shamardy]

@tonymorony @artemii235 should spv proof be used in AirDEX/Mobile, or will AirDEX/Mobile only connect to trusted electrum servers?

True simple payment verification requires downloading and saving the block headers for every coin when activating for the first time, this will have big storage requirements to activate multiple coins. Also coin activation time will go up, I tested downloading and saving all block headers for BTC and it took about 5 minutes to activate BTC with spv enabled. For other coins with less blocktime than btc, it will take much longer. I discussed this with some solutions before in this comment #1339 (comment).

As for the current issue, as a hotfix I can move enable_spv_proof flag to the electrum server request since this needs to be true for non-trusted servers only and then we can add if a server can be trusted or not to this list https://github.com/KomodoPlatform/coins/tree/master/electrums. What do you think @artemii235?

One last note, this error happens because of this https://github.com/KomodoPlatform/atomicDEX-API/blob/1438bf91bfb8e897ce8ff4d93badbba0a6edbb39/mm2src/coins/utxo/utxo_indexedb_block_header_storage.rs#L27-L29 which causes an infinite loop here https://github.com/KomodoPlatform/atomicDEX-API/blob/1438bf91bfb8e897ce8ff4d93badbba0a6edbb39/mm2src/coins/utxo/utxo_builder/utxo_arc_builder.rs#L226-L234
So, a permanent solution is to implement BlockHeaderStorageOps for IndexedDB but we have to agree on the solution for the problems I discussed above before doing that.

[anarkiVan]

@tonymorony @anarkiVan we should probably remove this flag from the coins repo at all for air_dex

I think that we can remove flag for cosmos demo, but after we need a solution for WASM.

[sergeyboyko0791]

Close as completed