Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistent Parameter Names #125

Open
jzwart opened this issue May 22, 2017 · 1 comment
Open

Consistent Parameter Names #125

jzwart opened this issue May 22, 2017 · 1 comment

Comments

@jzwart
Copy link
Member

jzwart commented May 22, 2017

Rename fitted parameters that are returned when using attr() to make consistent among models. For example, C[1] and C[2] in the bayes model vs. gppCoeff and rCoeff in the mle model.

@rBatt
Copy link
Contributor

rBatt commented May 22, 2017

This could break old code (thinking primarily of LM's users, but we'd also have to look throughout the package code, like in metab(), to make sure any change is consistent).

I agree that this seems desirable.

Alternative might be to add a getCoef() function with a 'method' for each type of model (except BK). But your suggestion seems better to me --- just need to recognize that people who used old versions won't be able to run old code with new version. This incompatibility might warrant incrementing the major version number. Therefore, perhaps such a change should be implemented when we have more significant changes to implement, too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants