Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace run_example_sim? #247

Open
hdugan opened this issue Jun 5, 2019 · 3 comments
Open

replace run_example_sim? #247

hdugan opened this issue Jun 5, 2019 · 3 comments

Comments

@hdugan
Copy link
Collaborator

hdugan commented Jun 5, 2019

A lot of the example codes rely on run_example_sim to create an output.nc file.

Since GLMr is not being maintained, and likely to shift towards running GLM through docker, I suggest we avoid running GLM in glmtools.

Instead we could host a small output.nc file in isnt/extdata
Currently I'm using one that is ~3.5 Mb. (2 day output for ~5 months). Could even make it smaller.

Thoughts?

@jordansread
Copy link
Member

Yeah, I was kind of wondering if we wanted to discuss making a hard pivot away from GLMr and also align w/ GLM V3 changed by simply creating glm3tools as a separate package (w/ a lot or most copied from it).

But perhaps that is a bad idea and would generate unnecessary work.

@hdugan
Copy link
Collaborator Author

hdugan commented Jun 5, 2019

Hmm. Hadn't considered that. Are there major changes between inputs or outputs of GLM V3 and V2?
If not, I think we should stick with the current package. But avoid any actual running of the model. Would be easy to change all of the examples.

We could change GLMr to docker based code. But users would still have to install docker.

@jordansread
Copy link
Member

I think the glm3.nml file is different, and not sure about any changes to the .nc file. I haven't tested GLM v3 intput/output w/ current glmtools. I think it depends how backwards compatible glmtools will remain once we move forward w/ GLM3 and dropping GLMr. I'm not sure about that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants