Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create error, warning, or ignore system for nml params that conflict #261

Open
jordansread opened this issue Jan 4, 2020 · 1 comment
Open

Comments

@jordansread
Copy link
Member

It seems failing early on setting params incorrectly would be helpful for users, especially with GLM errors aren't the easiest to track down. Starting with really simple ones first to create a pattern for implementing these rules would be ideal, making it easier for others to propose and implement more complex ones in the future.

For the time being, I am thinking about a couple of things:

  • Conflicts between lake_depth and the_depths where we should fail if max(the_depths) > lake_depth
  • variables that specify the length of a vector, but that vector is a different length (in this case, GLM will ignore the values after the specified length), such as bsn_vals and its relationship to H and A. (Others are csv_point_nvars, num_depths, num_inflows, inflow_varnum, num_outlet, n_zones and probably additional...). If using a default, perhaps these should warn instead of error?

Seems like a good starting point. Would be nice to be able to avoid errors or warnings if you want, so that should be coded in the validation checker.

@jordansread jordansread changed the title Create error, warning, or ignore system for params that conflict Create error, warning, or ignore system for nml params that conflict Jan 4, 2020
jordansread pushed a commit to jordansread/glmtools that referenced this issue Jan 8, 2020
@jordansread
Copy link
Member Author

Another tricky one that will cause a GLM v3.1 segfault but not let you know why: when crest_elev is below the bottom of H

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant