From c770e696f17e29479bcba9ad10bde17da1776f91 Mon Sep 17 00:00:00 2001 From: Philip Top Date: Tue, 20 Sep 2022 17:50:20 -0700 Subject: [PATCH 01/16] Sanitizer tests (#2439) * Attempt at fixing the race conditions from callback Federate Note: these race conditions don't really affect operations * try some tweaks on the callback tests * just remove some tests from the sanitizers * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * clang-tidy fixes * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * remove a few more tests from coverage Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> --- scripts/run-coverage-tests.sh | 6 +-- .../application_api/AsyncFedCallInfo.hpp | 2 +- src/helics/application_api/Federate.cpp | 15 +++--- src/helics/application_api/FederateInfo.cpp | 2 +- src/helics/core/CommonCore.cpp | 24 +++++---- src/helics/core/CommonCore.hpp | 2 +- src/helics/core/Core.hpp | 3 +- src/helics/core/EmptyCore.cpp | 5 +- src/helics/core/EmptyCore.hpp | 2 +- src/helics/network/NetworkCommsInterface.cpp | 2 +- .../application_api/CallbackFederateTests.cpp | 52 +++++++++++-------- .../helics/application_api/FederateTests.cpp | 8 +-- tests/helics/core/BrokerClassTests.cpp | 2 +- 13 files changed, 72 insertions(+), 53 deletions(-) diff --git a/scripts/run-coverage-tests.sh b/scripts/run-coverage-tests.sh index 367bd8cc0b..9b44e946a4 100755 --- a/scripts/run-coverage-tests.sh +++ b/scripts/run-coverage-tests.sh @@ -1,14 +1,14 @@ #!/bin/bash tests=( - ./bin/core-tests - ./bin/common-tests + "./bin/core-tests --gtest_filter=-*nocov*" + "./bin/common-tests --gtest_filter=-*nocov*" "./bin/system-tests --gtest_filter=-*nocov*" "./bin/helics_apps-tests --gtest_filter=-*nocov*" "./bin/shared-library-tests-cpp --gtest_filter=-*death*:*nocov*" "./bin/shared-library-tests --gtest_filter=-*death*:*nocov*" "./bin/application-api-tests --gtest_filter=-*nocov*" "./bin/helics_webserver-tests --gtest_filter=-*nocov*" - "./bin/network-tests --gtest_filter=*" + "./bin/network-tests --gtest_filter=-*nocov*" ) SUMRESULT=0 diff --git a/src/helics/application_api/AsyncFedCallInfo.hpp b/src/helics/application_api/AsyncFedCallInfo.hpp index bb5adcde3a..d4de4cca29 100644 --- a/src/helics/application_api/AsyncFedCallInfo.hpp +++ b/src/helics/application_api/AsyncFedCallInfo.hpp @@ -15,7 +15,7 @@ namespace helics { /** helper class for Federate info that holds the futures for asynchronous calls*/ class AsyncFedCallInfo { public: - std::future initFuture; /**future for the Enter initialization call*/ + std::future initFuture; /**future for the Enter initialization call*/ std::future execFuture; /** future for the enter execution mode call*/ std::future