-
Notifications
You must be signed in to change notification settings - Fork 39
GPII-4517: Added workflow for github actions #329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
javihernandez
wants to merge
8
commits into
GPII:master
Choose a base branch
from
javihernandez:GPII-4517
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 4 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
f0bddf2
GPII-4517: Added workflow for github actions
javihernandez bc79436
GPII-4517: Added lint step
javihernandez bab3770
GPII-4517: Use npx to run locally installed grunt cli when linting
javihernandez 94af4a3
GPII-4517: Linted changes
javihernandez 8e8d1ed
GPII-4517: Updated CouchDB script to work on github-hosted windows
javihernandez 019e5e9
GPII-4517: Updated universal reference
javihernandez 5156e59
GPII-4517: Updated workflow to run acceptance tests
javihernandez 0e050b7
GPII-4517: Updated universal reference
javihernandez File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,39 @@ | ||
| name: gpii-windows node tests | ||
|
|
||
| on: [push, pull_request] | ||
|
|
||
| jobs: | ||
| build: | ||
| runs-on: windows-latest | ||
| env: | ||
| VCTargetsPath: 'C:\Program Files (x86)\MSBuild\Microsoft.Cpp\v4.0\v140' | ||
| steps: | ||
| - uses: javihernandez/setup-node-nvm@input-arch-field | ||
| with: | ||
| node-version: "10.11.0" | ||
| node-arch: "32" | ||
| node-mirror: "https://nodejs.org/download/release/" | ||
|
|
||
| - uses: actions/checkout@v2 | ||
| - uses: actions/setup-python@v2 | ||
| with: | ||
| python-version: '2.7.17' | ||
|
|
||
| - name: Install vcbuildtools | ||
| run: choco install vcbuildtools -ia '/InstallSelectableItems VisualCppBuildTools_ATLMFC_SDK;VisualCppBuildTools_NETFX_SDK' -y | ||
| - name: Install Windows 10 SDK | ||
| run: choco install windows-sdk-10-version-1809-all --version=10.0.17763.1 -y | ||
| - name: Install MS Build Tools | ||
| run: choco install microsoft-build-tools -y | ||
| - name: Install VisualCppBuildTools | ||
| run: choco install visualcppbuildtools -y | ||
| - run: npm config set msvs_version 2015 --global | ||
| - run: npm config set python python2.7 | ||
|
|
||
| - run: npm install | ||
|
|
||
| - name: Pass linter | ||
| run: npx grunt lint | ||
|
|
||
| - name: Run node unit tests | ||
| run: node tests/UnitTests.js | ||
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
34 changes: 19 additions & 15 deletions
34
gpii/node_modules/nativeSettingsHandler/test/testNativeSettingsHandler.js
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
4 changes: 2 additions & 2 deletions
4
gpii/node_modules/processHandling/test/testProcessHandling.js
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Worth trying a few acceptance tests? Do they run?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They would run, but if we want to run them as they are we'd need to set up couchdb. I can definitely take a look if there's an easy way to set up couchdb in the github-hosted windows images. I think I can even take a look at creating a small github action that sets up couchdb on windows (I already did something similar for our vagrant boxes), but again, I'd need some time.
Another option would be to run the acceptanceTests against a file-based prefsServer, which I think it's not the way we want to test things.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So yeah, let me give a try at setting up couchdb, I'll keep you posted 😉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done, here's the link to the CI pass https://github.com/javihernandez/windows/runs/1415137751?check_suite_focus=true